iOS: Add getContentSizeMultiplier & event #11010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives apps the ability to find out the current scaling factor for fonts on the device. An event was also added so that apps can find out when this value changes.
facebook-github-bot
added
the
CLA Signed
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Since it looks like the method and event deal purely with fonts:
What do you think of the following naming?
But I see this reads Should the method and event be declared and documented in a JS file somewhere? |
|
Martin, I responded in #11008 (comment). Let's discuss it there. |
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: Corresponding Android PR: facebook#11008 This gives apps the ability to find out the current scaling factor for fonts on the device. An event was also added so that apps can find out when this value changes. **Test plan (required)** Verified that the getter and the event work properly in a test app. Also, this change is used in my team's app. Adam Comella Microsoft Corp. Closes facebook#11010 Differential Revision: D4207620 Pulled By: ericvicenti fbshipit-source-id: b3f6f4a412557ba97e1f5fb63446c7ff9a2ff753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding Android PR: #11008
This gives apps the ability to find out the current scaling factor for fonts on the device. An event was also added so that apps can find out when this value changes.
Test plan (required)
Verified that the getter and the event work properly in a test app. Also, this change is used in my team's app.
Adam Comella
Microsoft Corp.