Emit willfocus from immediatelyResetRouteStack
#10125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Navigator component inconsistently emits the `willfocus` event. While it is emitted in `Navigator#resetTo`, `Navigator#push`, `Navigator#pop` and event `Navigator#replaceAtIndex` it is not emitted from `Navigator#immediatelyResetRouteStack`. This leads to surprising inconsistencies when working with these events. With the PR I suggest to emit the `willfocus` event before resetting the route stack.
ghost
added
GH Review: review-needed
CLA Signed
|
@dzautner updated the pull request - view changes |
ghost
added
the
CLA Signed
|
@dzautner updated the pull request - view changes |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
the
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
the
CLA Signed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Navigator component inconsistently emits the
willfocusevent.While it is emitted in
Navigator#resetTo,Navigator#push,Navigator#popand eventNavigator#replaceAtIndexit is not emitted fromNavigator#immediatelyResetRouteStack. This leads to surprising inconsistencies when working with these events.With the PR I suggest to emit the
willfocusevent before resetting the route stack.