-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SliderIOS: minimumValue, maximumValue props ignored? #442
Labels
Resolution: Locked
This issue was locked by the bot.
Comments
yea. i stumbled upon the same. |
+1 - found this also - min and max values don't work |
Made a quick PR to fix this if you guys want to try it out. Thanks! |
+1 thanks for fixing it @donyu, hopefully it will be merged soon. |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this issue
Apr 13, 2015
Summary: Noticed that the minimumValue and maximumValue for the SliderIOS component isn't actually picked up by the native slider that gets rendered. Issue facebook#442 Closes facebook#583 Github Author: Don Yu <donyu8@gmail.com> Test Plan: Add minimumValue and maximumValue prop to <SliderIOS> component in SliderIOSExample.js for UIExplorer (see screenshots) ![sliderios_maximumvalue](https://cloud.githubusercontent.com/assets/1103836/6946764/9ebe8db8-d870-11e4-84e5-7c31a955f9c0.png) ![sliderios_minimumvalue](https://cloud.githubusercontent.com/assets/1103836/6946765/9ec0031e-d870-11e4-8a1b-2371a5aa033a.png)
vjeux
pushed a commit
to vjeux/react-native
that referenced
this issue
Apr 14, 2015
Summary: Noticed that the minimumValue and maximumValue for the SliderIOS component isn't actually picked up by the native slider that gets rendered. Issue facebook#442 Closes facebook#583 Github Author: Don Yu <donyu8@gmail.com> Test Plan: Add minimumValue and maximumValue prop to <SliderIOS> component in SliderIOSExample.js for UIExplorer (see screenshots) ![sliderios_maximumvalue](https://cloud.githubusercontent.com/assets/1103836/6946764/9ebe8db8-d870-11e4-84e5-7c31a955f9c0.png) ![sliderios_minimumvalue](https://cloud.githubusercontent.com/assets/1103836/6946765/9ec0031e-d870-11e4-8a1b-2371a5aa033a.png)
vjeux
pushed a commit
to vjeux/react-native
that referenced
this issue
Apr 15, 2015
Summary: Noticed that the minimumValue and maximumValue for the SliderIOS component isn't actually picked up by the native slider that gets rendered. Issue facebook#442 Closes facebook#583 Github Author: Don Yu <donyu8@gmail.com> Test Plan: Add minimumValue and maximumValue prop to <SliderIOS> component in SliderIOSExample.js for UIExplorer (see screenshots) ![sliderios_maximumvalue](https://cloud.githubusercontent.com/assets/1103836/6946764/9ebe8db8-d870-11e4-84e5-7c31a955f9c0.png) ![sliderios_minimumvalue](https://cloud.githubusercontent.com/assets/1103836/6946765/9ec0031e-d870-11e4-8a1b-2371a5aa033a.png)
@brentvatne Thanks for catching the interplay issue! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/facebook/react-native/blob/master/Libraries/Components/SliderIOS/SliderIOS.js#L82
The text was updated successfully, but these errors were encountered: