Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SliderIOS: minimumValue, maximumValue props ignored? #442

Closed
gcanti opened this issue Mar 29, 2015 · 6 comments
Closed

SliderIOS: minimumValue, maximumValue props ignored? #442

gcanti opened this issue Mar 29, 2015 · 6 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@gcanti
Copy link

gcanti commented Mar 29, 2015

https://github.com/facebook/react-native/blob/master/Libraries/Components/SliderIOS/SliderIOS.js#L82

...

  render: function() {
    return (
      <RCTSlider
        style={[styles.slider, this.props.style]}
        value={this.props.value}
        onChange={this._onValueChange}
      />
    );
  }

...
@kangguru
Copy link

yea. i stumbled upon the same.

@davidgtonge
Copy link

+1 - found this also - min and max values don't work

@donyu
Copy link
Contributor

donyu commented Apr 1, 2015

Made a quick PR to fix this if you guys want to try it out. Thanks!

@benigeri
Copy link

benigeri commented Apr 3, 2015

+1 thanks for fixing it @donyu, hopefully it will be merged soon.

vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 13, 2015
Summary:
Noticed that the minimumValue and maximumValue for the SliderIOS component isn't actually picked up by the native slider that gets rendered. Issue facebook#442

Closes facebook#583
Github Author: Don Yu <donyu8@gmail.com>

Test Plan:
 Add minimumValue and maximumValue prop to <SliderIOS> component in SliderIOSExample.js for UIExplorer (see screenshots)

![sliderios_maximumvalue](https://cloud.githubusercontent.com/assets/1103836/6946764/9ebe8db8-d870-11e4-84e5-7c31a955f9c0.png)
![sliderios_minimumvalue](https://cloud.githubusercontent.com/assets/1103836/6946765/9ec0031e-d870-11e4-8a1b-2371a5aa033a.png)
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 14, 2015
Summary:
Noticed that the minimumValue and maximumValue for the SliderIOS component isn't actually picked up by the native slider that gets rendered. Issue facebook#442

Closes facebook#583
Github Author: Don Yu <donyu8@gmail.com>

Test Plan:
 Add minimumValue and maximumValue prop to <SliderIOS> component in SliderIOSExample.js for UIExplorer (see screenshots)

![sliderios_maximumvalue](https://cloud.githubusercontent.com/assets/1103836/6946764/9ebe8db8-d870-11e4-84e5-7c31a955f9c0.png)
![sliderios_minimumvalue](https://cloud.githubusercontent.com/assets/1103836/6946765/9ec0031e-d870-11e4-8a1b-2371a5aa033a.png)
vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 15, 2015
Summary:
Noticed that the minimumValue and maximumValue for the SliderIOS component isn't actually picked up by the native slider that gets rendered. Issue facebook#442

Closes facebook#583
Github Author: Don Yu <donyu8@gmail.com>

Test Plan:
 Add minimumValue and maximumValue prop to <SliderIOS> component in SliderIOSExample.js for UIExplorer (see screenshots)

![sliderios_maximumvalue](https://cloud.githubusercontent.com/assets/1103836/6946764/9ebe8db8-d870-11e4-84e5-7c31a955f9c0.png)
![sliderios_minimumvalue](https://cloud.githubusercontent.com/assets/1103836/6946765/9ec0031e-d870-11e4-8a1b-2371a5aa033a.png)
@brentvatne
Copy link
Collaborator

#583 was a good start, #835 fixes interplay between min/max value and initial value

@donyu
Copy link
Contributor

donyu commented Apr 22, 2015

@brentvatne Thanks for catching the interplay issue!

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants