-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching blobs from filesystem results in blob-size: 0 #19717
Comments
initial blob fetch support was added with the commits be56a3e and 854c233 by @satya164 and @fkgozali. Possible impacting commits in the last release were 122b3791ede095345f44666691aa9ce5aa7f725a and 093a78d by @janicduplessis and @grabbou. Any ideas on this? |
Does anyone know of any workarounds for this? |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
This issue is still present in the latest React Native release (0.57.4) |
This describes the same behaviour: #21092 |
…22063) Summary: This is a problem that is discussed in issue #21092 Related issues: #21851 #19717 Found the code to eventually fix this issue [here](https://github.com/github/fetch/blob/899b155746630c32d83ee29a38642da16b314ecb/fetch.js#L486) - [x] Fetching an image locally and check if the blob is there, as well as its size > 0. ___ Help reviewers and the release process by writing your own release notes. See below for an example. [GENERAL] [ENHANCEMENT] [whatwg-fetch] - set blob as default XMLHttpRequest header response type if supported Pull Request resolved: #22063 Differential Revision: D13408797 Pulled By: cpojer fbshipit-source-id: 9822d5a7e24bacd72838f3fc9a61b1a97b44484b
It looks like this commit fixes the issue but it hasn't been released to a tagged version, any chance that'll happen soon? 🙏 |
…acebook#22063) Summary: This is a problem that is discussed in issue facebook#21092 Related issues: facebook#21851 facebook#19717 Found the code to eventually fix this issue [here](https://github.com/github/fetch/blob/899b155746630c32d83ee29a38642da16b314ecb/fetch.js#L486) - [x] Fetching an image locally and check if the blob is there, as well as its size > 0. ___ Help reviewers and the release process by writing your own release notes. See below for an example. [GENERAL] [ENHANCEMENT] [whatwg-fetch] - set blob as default XMLHttpRequest header response type if supported Pull Request resolved: facebook#22063 Differential Revision: D13408797 Pulled By: cpojer fbshipit-source-id: 9822d5a7e24bacd72838f3fc9a61b1a97b44484b
This commit has been released as part of 0.59 so I'll close the issue. Thanks everyone 😄 |
Environment
Description
After upgrading from
react native 0.55.4
(which introduced blob fetching) toreact native 0.56.0-rc
I experience issues with blob fetching on iOS (android not tested). When fetching an image/video from filesystem and building a blob from it, the blob-size
is0
.I am aware of this react-native-blob-test repo but these tests doesn't seem to fail on
size === 0
since an&&
operator is used instead of an||
operator : https://github.com/expo/react-native-blob-test/blob/c0dbd66f4e2a193a5031c52c9b49ea2a6b4419ed/index.common.js#L291Steps to Reproduce
https://github.com/expo/react-native-blob-test/blob/master/index.common.js#L134
Expected Behavior
Since the image/video exists (i can save it via
CameraRoll.saveToCameraRoll
) the resulting blob should have a valid size (positive number).Actual Behavior
The blob has a size of
0
.The text was updated successfully, but these errors were encountered: