Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nesting an Image and a Text which has lineHeight in an Text will display wrong #17750

Closed
JosephPoplar opened this issue Jan 26, 2018 · 4 comments
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@JosephPoplar
Copy link

JosephPoplar commented Jan 26, 2018

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

OS: macOS High Sierra 10.13.2
Node: 8.9.1
Yarn: Not Found
npm: 4.6.1
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4408382

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.52.0 => 0.52.0

Target Platform: iOS (11)

Steps to Reproduce

1.nest a Text with some text and an Image in a Text
2.give the nested Text a style with lineHeight 12
3.run the app

Expected Behavior

nest Text should render normal with lineHeight 12 , and there should be an Image below it.
rnbug-01

Actual Behavior

the Image was lost ,and the content of the nested Text render as one single line without line break.
rnbug-02

Reproducible Demo

https://snack.expo.io/@josephpoplar/reactnative-52-nesting-text-demo

Update

Environment

OS: macOS High Sierra 10.13.3
Node: 8.9.1
Yarn: Not Found
npm: 4.6.1
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4408382

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3

Still error in 53.0.

Demo

ReactNativeTextDemo.zip
please run npm install after opening the project.

@JosephPoplar JosephPoplar changed the title Nest a Text with lineHeight and an Image In Text will display wrong Nesting an Image and a Text which has lineHeight In an Text will display wrong Jan 26, 2018
@JosephPoplar JosephPoplar changed the title Nesting an Image and a Text which has lineHeight In an Text will display wrong Nesting an Image and a Text which has lineHeight in an Text will display wrong Jan 26, 2018
@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@salmanwaheed
Copy link

salmanwaheed commented Feb 24, 2018 via email

@JosephPoplar
Copy link
Author

Still error in 53.0

@junchenjun
Copy link

Still happens in the latest version

@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

4 participants