Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePickerIOS - locale props not working #17696

Closed
muthuraman007 opened this issue Jan 22, 2018 · 9 comments
Closed

DatePickerIOS - locale props not working #17696

muthuraman007 opened this issue Jan 22, 2018 · 9 comments
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@muthuraman007
Copy link

muthuraman007 commented Jan 22, 2018

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 8.9.0
Yarn: 0.27.5
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.1 Build version 9855
Android Studio: Not Found

Packages: (wanted => installed)
react: 16.1.1=> 16.1.1
react-native: 0.50.3 => 0.50.3

Steps to Reproduce

  1. Add DatePickerIOS component
  2. set locale props as "en_GB@calendar=buddhist" or "th_TH" or "zh_HK"
  3. set mode props as "date"

Expected Behavior

Date picker should show buddhist calendar type.

Actual Behavior

It showing default (gregorian) calendar type.

@muthuraman007 muthuraman007 changed the title DatDatePickerIOS - locale not working DatePickerIOS - locale not working Jan 22, 2018
@muthuraman007 muthuraman007 changed the title DatePickerIOS - locale not working DatePickerIOS - locale props not working Jan 22, 2018
@muthuraman007
Copy link
Author

@hramos Need your help

@michalpokojski
Copy link

Confirm locale prop doesn't work. React 16.2.0, react-native 0.51.0

@404sand808s
Copy link

404sand808s commented Jan 29, 2018

Confirming as well. React 16.2.0, react-native 0.51.0.

@gedeagas
Copy link
Contributor

I think I know what causes this problem.
will try to submit a PR in the coming days

@404sand808s
Copy link

Actually just realized today that they've fixed this issue in 0.52.0. Upgraded (or rather re-initiated and ported, upgrade process was hell) and now it works.

@gedeagas
Copy link
Contributor

@404sand808s
yep confirmed this issue was fixed at 0.52.0 release

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@salmanwaheed
Copy link

salmanwaheed commented Feb 24, 2018 via email

@salmanwaheed
Copy link

salmanwaheed commented Feb 24, 2018 via email

@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

6 participants