-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected keyboard dismiss in ScrollView when soft keyboard appears. #16635
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Summary: Trying this again with a fresh pullrequest as the old one kept having issued due to rebasing. Fixes facebook#16635 the issue is a little serious if you use a scrollview which contains textinput, you will never get a chance to input something since keyboard will always be dismissed because of on-drag event if your scroll-view use the property: keyboardDismissMode ='on-drag' verify the issue facebook#16635 and tested this fix worked [ANDROID] [BUGFIX] [ScrollView] - Check that isTouching is also set when dismissing keyboard with on-drag android. Closes facebook#18785 Differential Revision: D7569815 Pulled By: hramos fbshipit-source-id: 2a07369297ce9ce5a7714e513ccb480ee7011a4d
Summary: Trying this again with a fresh pullrequest as the old one kept having issued due to rebasing. Fixes facebook#16635 the issue is a little serious if you use a scrollview which contains textinput, you will never get a chance to input something since keyboard will always be dismissed because of on-drag event if your scroll-view use the property: keyboardDismissMode ='on-drag' verify the issue facebook#16635 and tested this fix worked [ANDROID] [BUGFIX] [ScrollView] - Check that isTouching is also set when dismissing keyboard with on-drag android. Closes facebook#18785 Differential Revision: D7569815 Pulled By: hramos fbshipit-source-id: 2a07369297ce9ce5a7714e513ccb480ee7011a4d
Summary: Trying this again with a fresh pullrequest as the old one kept having issued due to rebasing. Fixes facebook#16635 the issue is a little serious if you use a scrollview which contains textinput, you will never get a chance to input something since keyboard will always be dismissed because of on-drag event if your scroll-view use the property: keyboardDismissMode ='on-drag' verify the issue facebook#16635 and tested this fix worked [ANDROID] [BUGFIX] [ScrollView] - Check that isTouching is also set when dismissing keyboard with on-drag android. Closes facebook#18785 Differential Revision: D7569815 Pulled By: hramos fbshipit-source-id: 2a07369297ce9ce5a7714e513ccb480ee7011a4d
Summary: Trying this again with a fresh pullrequest as the old one kept having issued due to rebasing. Fixes facebook#16635 the issue is a little serious if you use a scrollview which contains textinput, you will never get a chance to input something since keyboard will always be dismissed because of on-drag event if your scroll-view use the property: keyboardDismissMode ='on-drag' verify the issue facebook#16635 and tested this fix worked [ANDROID] [BUGFIX] [ScrollView] - Check that isTouching is also set when dismissing keyboard with on-drag android. Closes facebook#18785 Differential Revision: D7569815 Pulled By: hramos fbshipit-source-id: 2a07369297ce9ce5a7714e513ccb480ee7011a4d
I'm curious about the fix for this issue. ScrollViews on Android with the keyboardDismissMode set to on-drag, no longer dismiss the keyboard. For example
I would expect that the keyboard would dismiss on drag for Android as it does in iOS. The |
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Scanning folders for symlinks in /Users/jiaminglu/test/node_modules (20ms)
Environment:
OS: macOS Sierra 10.12.6
Node: 8.2.1
Yarn: 0.27.5
npm: 5.3.0
Watchman: 4.9.0
Xcode: Xcode 9.1 Build version 9B55
Android Studio: 3.0 AI-171.4408382
Packages:
react: 16.0.0-beta.5 => 16.0.0-beta.5
react-native: 0.49.5 => 0.49.5
Steps to Reproduce
Expected Behavior
The keyboard should appear.
Actual Behavior
The keyboard appears and then disappears immediately.
Reproducible Demo
Cause
When the TextInput clicked and soft keyboard appeared, the Android system pushes up the underlying EditText, and then the ScrollView detects a scroll event, dismissed the keyboard according to
keyboardDismissMode="on-drag"
, which I think should be handled ononScrollBeginDrag
instead.The text was updated successfully, but these errors were encountered: