Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView: refreshControl prop does not work if horizontal={true} #12139

Closed
joncursi opened this issue Feb 1, 2017 · 2 comments
Closed

ListView: refreshControl prop does not work if horizontal={true} #12139

joncursi opened this issue Feb 1, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@joncursi
Copy link
Contributor

joncursi commented Feb 1, 2017 •
edited
Loading

I noticed that on the ListView component, the refreshControl prop is omitted / fails silently if the ListView is set to scroll horizontally with horizontal={true}. Perhaps this is best anyway, as the design would be a bit funky for a horizontal swipe to refresh, but maybe it's worth noting this behavior in the documentation.
@janicduplessis
Copy link
Contributor

Yea it's not supported on horizontal scroll views, feel free to send a PR to improve the doc. :)

@joncursi joncursi mentioned this issue Feb 1, 2017
Closed
@janicduplessis
Copy link
Contributor

@joncursi Thanks for the PR!

edmofro pushed a commit to edmofro/react-native that referenced this issue Feb 6, 2017
@joncursi
Update ScrollView docs - Fixes facebook#12139
c845298 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 7, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
83d343c 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
normanjoyner pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @normanjoyner
Update ScrollView docs - Fixes facebook#12139
4de5946 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
7a7932e 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
29117d2 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
7025724 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
1f0196d 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
2897a4e 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
90dac52 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
58eafe4 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
fd10074 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@joncursi @nicktate
Update ScrollView docs - Fixes facebook#12139
ec5b6e5 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
GaborWnuk pushed a commit to GaborWnuk/react-native that referenced this issue Feb 28, 2017
@joncursi
Update ScrollView docs - Fixes facebook#12139
8a83e5a 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
maarf pushed a commit to fullcontact/react-native that referenced this issue Apr 26, 2017
@joncursi @maarf
Update ScrollView docs - Fixes facebook#12139
a161834 
Summary:
Added a note to the `refreshControl` prop on ScrollView to call out that the prop only works for vertical ScrollViews.

Fixes facebook#12139
Closes facebook#12150

Differential Revision: D4508796

Pulled By: mkonicek

fbshipit-source-id: 8e71692f29ee175e32177c3a26a4ed2e8d14f139
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janicduplessis @joncursi @react-native-bot