Offsetting RefreshControl on iOS via progressViewOffset

[scarlac]

Description

An object class check for RefreshControl is hard-coded into ScrollView making it impossible to offset the pull-to-refresh loader via JS. Tinkering with the style prop on RefreshControl can cause crashes and strange visual artifacts. A native solution seems the only near-term viable option besides re-implementing everything from scratch.

I have a fix locally to make the Android-only property progressViewOffset on RefreshControl work on iOS as well.

I will submit a PR as soon as possible. Please reply here if there is any disinterest in resolving this issue by adding iOS support via progressViewOffset

Reproduction

1. Start a project
2. Set up a component
3. Add the refreshControl={<RefreshControl progressViewOffset={-13}/>} property.
4. Run in iOS simulator
5. Pull-down while list is at top
6. An activity indicator will slowly appear as you pull down.

The indicator does not move according to the progressViewOffset property on RefreshControl.

Additional Information

• React Native version: 0.36
• Platform: iOS 10.0
• Operating System: macOS 10.12.1

[brentvatne]

This would be nice to have! Looking forward to the PR @scarlac

[scarlac]

@brentvatne: Done. Should I include the documentation change in this PR as well?

[mountainmoon]

This is a very usefull feature, why it has not be merged till now ? @scarlac @brentvatne

[scarlac]

@mountainmoon Too long time passed so I had to move on. I'm now working on other projects, so I unfortunately don't have the time to fix the issue that was raised by @arsen

If you can fix the issue I think @hramos will be willing to reopen it

[hramos]

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

• Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
• If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
• Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

[Bonobomagno]

Still an issue on 0.55. The workarounds are pretty bad.

[hramos]

@Bonobomagno happy to re-open the issue if you are ready to send a PR.