Skip to content

Commit

Permalink
Document image blurRadius is working on Android too
Browse files Browse the repository at this point in the history
Summary:
Hi,

I saw blurRadius is now working on Android. Updated the doc to show it.

It is available since 0.44, see 0b34809

See RNTester screenshot on Android:
![blur-android](https://cloud.githubusercontent.com/assets/57791/26244353/97fa4f96-3c8f-11e7-8910-5c60f5ad93fc.png)

Also I noticed it's a bit different than on iOS:
![blur-ios](https://cloud.githubusercontent.com/assets/57791/26244396/bbaf9158-3c8f-11e7-96cc-534d8ee042fb.png)

Looking briefly at the code, it looks like it's caused by the fact that the Android version applies blur to the original image data in full size (and applies `PixelUtil.toPixelFromDIP(blurRadius)`), but the iOS version applies it to the resized version.
I'll open an issue for this.
Closes #14055

Differential Revision: D5103240

Pulled By: javache

fbshipit-source-id: 16d8c8755cd27a4f13c28e8831017733327ca491
  • Loading branch information
jeanregisser authored and facebook-github-bot committed May 22, 2017
1 parent 872fbc2 commit fc09c54
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Libraries/Image/Image.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ const Image = React.createClass({
accessibilityLabel: PropTypes.node,
/**
* blurRadius: the blur radius of the blur filter added to the image
* @platform ios
*/
blurRadius: PropTypes.number,
/**
Expand Down

1 comment on commit fc09c54

@mikelambert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeanregisser , thanks for the investigation here. Did you ever file a bug on (or perhaps fix) the platform-specific differences in blurRadius?

Please sign in to comment.