Fix commands with no args

Summary: Fixing a typo Reviewed By: JoshuaGross Differential Revision: D16434634 fbshipit-source-id: 72a6b698bcd0ba9c10dfbdf264011e0a31ea06b6
facebook · Jul 24, 2019 · fbd5dee · fbd5dee
1 parent 4eca2e2
commit fbd5dee
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 12 deletions.
diff --git a/packages/react-native-codegen/src/generators/components/GeneratePropsJavaDelegate.js b/packages/react-native-codegen/src/generators/components/GeneratePropsJavaDelegate.js
@@ -129,15 +129,14 @@ function getCommandArgJavaType(param) {
 }
 
 function getCommandArguments(command: CommandTypeShape): string {
-  const commandArgs = command.typeAnnotation.params
-    .map((param, index) => {
+  return [
+    'view',
+    ...command.typeAnnotation.params.map((param, index) => {
       const commandArgJavaType = getCommandArgJavaType(param);
 
       return `args.${commandArgJavaType}(${index})`;
-    })
-    .join(', ');
-
-  return `view, ${commandArgs}`;
+    }),
+  ].join(', ');
 }
 
 function generateCommandCasesString(

diff --git a/packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js b/packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js
@@ -107,15 +107,14 @@ function getCommandArguments(
   command: CommandTypeShape,
   componentName: string,
 ): string {
-  const commandArgs = command.typeAnnotation.params
-    .map(param => {
+  return [
+    'T view',
+    ...command.typeAnnotation.params.map(param => {
       const commandArgJavaType = getCommandArgJavaType(param);
 
       return `${commandArgJavaType} ${param.name}`;
-    })
-    .join(', ');
-
-  return `T view, ${commandArgs}`;
+    }),
+  ].join(', ');
 }
 
 function generateCommandsString(

diff --git a/packages/react-native-codegen/src/generators/components/__test_fixtures__/fixtures.js b/packages/react-native-codegen/src/generators/components/__test_fixtures__/fixtures.js
@@ -921,6 +921,14 @@ const COMMANDS: SchemaType = {
           events: [],
           props: [],
           commands: [
+            {
+              name: 'flashScrollIndicators',
+              optional: false,
+              typeAnnotation: {
+                type: 'FunctionTypeAnnotation',
+                params: [],
+              },
+            },
             {
               name: 'hotspotUpdate',
               optional: false,

diff --git a/.../src/generators/components/__tests__/__snapshots__/GeneratePropsJavaDelegate-test.js.snap b/.../src/generators/components/__tests__/__snapshots__/GeneratePropsJavaDelegate-test.js.snap
@@ -96,6 +96,9 @@ public class CommandNativeComponentViewManagerDelegate<T extends View> {
   }
 
   public void receiveCommand(CommandNativeComponentInterface<T> viewManager, T view, String commandName, ReadableArray args) {
+    case \\"flashScrollIndicators\\":
+      viewManager.flashScrollIndicators(view);
+      break;
     case \\"hotspotUpdate\\":
       viewManager.hotspotUpdate(view, args.getInt(0), args.getInt(1));
       break;

diff --git a/...src/generators/components/__tests__/__snapshots__/GeneratePropsJavaInterface-test.js.snap b/...src/generators/components/__tests__/__snapshots__/GeneratePropsJavaInterface-test.js.snap
@@ -61,6 +61,7 @@ import android.view.View;
 
 public interface CommandNativeComponentViewManagerInterface<T extends View> {
   // No props
+  void flashScrollIndicators(T view);
   void hotspotUpdate(T view, int x, int y);
   void scrollTo(T view, int y, boolean animated);
 }

diff --git a/...degen/src/generators/components/__tests__/__snapshots__/GenerateViewConfigJs-test.js.snap b/...degen/src/generators/components/__tests__/__snapshots__/GenerateViewConfigJs-test.js.snap
@@ -144,6 +144,14 @@ export const __INTERNAL_VIEW_CONFIG = CommandNativeComponentViewConfig;
 export default nativeComponentName;
 
 export const Commands = {
+    flashScrollIndicators(ref) {
+        UIManager.dispatchViewCommand(
+          findNodeHandle(ref),
+          UIManager.getViewManagerConfig(\\"CommandNativeComponent\\").Commands.flashScrollIndicators,
+          []
+        );
+    },
+
     hotspotUpdate(ref, x, y) {
         UIManager.dispatchViewCommand(
           findNodeHandle(ref),