0.87.0 in xplat/js

Summary: allow-large-files Reviewed By: samwgoldman Differential Revision: D13230018 fbshipit-source-id: f07e2371a3b7382de0592cc7c7b20e7f4faa6889
facebook · Nov 29, 2018 · ef2084c · ef2084c
1 parent 585f7b9
commit ef2084c
Show file tree

Hide file tree

Showing 11 changed files with 38 additions and 12 deletions.
diff --git a/.flowconfig b/.flowconfig
@@ -98,4 +98,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.86.0
+^0.87.0
diff --git a/.flowconfig.android b/.flowconfig.android
@@ -98,4 +98,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.86.0
+^0.87.0
diff --git a/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js b/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js
@@ -231,6 +231,9 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
     return (
       <AndroidDrawerLayout
         {...props}
+        /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+         * suppresses an error found when Flow v0.87 was deployed. To see the
+         * error, delete this comment and run Flow. */
         ref={this._nativeRef}
         drawerWidth={this.props.drawerWidth}
         drawerPosition={this.props.drawerPosition}
@@ -322,18 +325,30 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
    * Native methods
    */
   blur() {
+    /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+     * suppresses an error found when Flow v0.87 was deployed. To see the
+     * error, delete this comment and run Flow. */
     nullthrows(this._nativeRef.current).blur();
   }
 
   focus() {
+    /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+     * suppresses an error found when Flow v0.87 was deployed. To see the
+     * error, delete this comment and run Flow. */
     nullthrows(this._nativeRef.current).focus();
   }
 
   measure(callback: MeasureOnSuccessCallback) {
+    /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+     * suppresses an error found when Flow v0.87 was deployed. To see the
+     * error, delete this comment and run Flow. */
     nullthrows(this._nativeRef.current).measure(callback);
   }
 
   measureInWindow(callback: MeasureInWindowOnSuccessCallback) {
+    /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+     * suppresses an error found when Flow v0.87 was deployed. To see the
+     * error, delete this comment and run Flow. */
     nullthrows(this._nativeRef.current).measureInWindow(callback);
   }
 
@@ -342,6 +357,9 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
     onSuccess: MeasureLayoutOnSuccessCallback,
     onFail?: () => void,
   ) {
+    /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+     * suppresses an error found when Flow v0.87 was deployed. To see the
+     * error, delete this comment and run Flow. */
     nullthrows(this._nativeRef.current).measureLayout(
       relativeToNativeNode,
       onSuccess,
@@ -350,6 +368,9 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
   }
 
   setNativeProps(nativeProps: Object) {
+    /* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
+     * suppresses an error found when Flow v0.87 was deployed. To see the
+     * error, delete this comment and run Flow. */
     nullthrows(this._nativeRef.current).setNativeProps(nativeProps);
   }
 }

diff --git a/Libraries/Utilities/__tests__/setAndForwardRef-test.js b/Libraries/Utilities/__tests__/setAndForwardRef-test.js
@@ -88,6 +88,9 @@ describe('setAndForwardRef', () => {
 
     ReactTestRenderer.create(<TestComponentWithRef ref={createdRef} />);
 
+    /* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an
+     * error found when Flow v0.87 was deployed. To see the error, delete this
+     * comment and run Flow. */
     const val = createdRef.current && createdRef.current.testFunc();
 
     expect(innerFuncCalled).toBe(true);

diff --git a/RNTester/js/TextInputExample.android.js b/RNTester/js/TextInputExample.android.js
@@ -315,8 +315,6 @@ class SelectionExample extends React.Component<
           onChangeText={value => this.setState({value})}
           onSelectionChange={this.onSelectionChange.bind(this)}
           ref={textInput => (this._textInput = textInput)}
-          /* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was
-           * found when making Flow check .android.js files. */
           selection={this.state.selection}
           style={this.props.style}
           value={this.state.value}

diff --git a/ReactAndroid/src/androidTest/js/ScrollViewTestModule.js b/ReactAndroid/src/androidTest/js/ScrollViewTestModule.js
@@ -87,6 +87,9 @@ type State = {|
 |};
 
 class ScrollViewTestApp extends React.Component<Props, State> {
+  /* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an error
+   * found when Flow v0.87 was deployed. To see the error, delete this comment
+   * and run Flow. */
   scrollView = React.createRef();
   state = getInitialState();
 
@@ -121,6 +124,9 @@ class ScrollViewTestApp extends React.Component<Props, State> {
 }
 
 class HorizontalScrollViewTestApp extends React.Component<Props, State> {
+  /* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an error
+   * found when Flow v0.87 was deployed. To see the error, delete this comment
+   * and run Flow. */
   scrollView = React.createRef();
   state = getInitialState();
 

diff --git a/jest/preprocessor.js b/jest/preprocessor.js
@@ -33,7 +33,6 @@ const nodeOptions = babelRegisterOnly.config([nodeFiles]);
 
 babelRegisterOnly([]);
 
-/* $FlowFixMe(site=react_native_oss) */
 const transformer = require('metro/src/reactNativeTransformer');
 module.exports = {
   process(src /*: string */, file /*: string */) {

diff --git a/local-cli/bundle/buildBundle.js b/local-cli/bundle/buildBundle.js
@@ -13,7 +13,6 @@
 const log = require('../util/log').out('bundle');
 const Server = require('metro/src/Server');
 
-/* $FlowFixMe(site=react_native_oss) */
 const outputBundle = require('metro/src/shared/output/bundle');
 const path = require('path');
 const saveAssets = require('./saveAssets');

diff --git a/local-cli/templates/HelloWorld/_flowconfig b/local-cli/templates/HelloWorld/_flowconfig
@@ -67,4 +67,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 [version]
-^0.86.0
+^0.87.0
diff --git a/package.json b/package.json
@@ -221,7 +221,7 @@
     "eslint-plugin-prettier": "2.6.0",
     "eslint-plugin-react": "7.8.2",
     "eslint-plugin-react-native": "3.5.0",
-    "flow-bin": "^0.86.0",
+    "flow-bin": "^0.87.0",
     "jest": "24.0.0-alpha.6",
     "jest-junit": "5.2.0",
     "prettier": "1.13.6",

diff --git a/yarn.lock b/yarn.lock
@@ -2590,10 +2590,10 @@ flat-cache@^1.2.1:
     graceful-fs "^4.1.2"
     write "^0.2.1"
 
-flow-bin@^0.86.0:
-  version "0.86.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.86.0.tgz#153a28722b4dc13b7200c74b644dd4d9f4969a11"
-  integrity sha512-ulRvFH3ewGIYwg+qPk/OJXoe3Nhqi0RyR0wqgK0b1NzUDEC6O99zU39MBTickXvlrr6iwRO6Wm4lVGeDmnzbew==
+flow-bin@^0.87.0:
+  version "0.87.0"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.87.0.tgz#fab7f984d8cc767e93fa9eb01cf7d57ed744f19d"
+  integrity sha512-mnvBXXZkUp4y6A96bR5BHa3q1ioIIN2L10w5osxJqagAakTXFYZwjl0t9cT3y2aCEf1wnK6n91xgYypQS/Dqbw==
 
 for-in@^1.0.1, for-in@^1.0.2:
   version "1.0.2"