Skip to content

Commit

Permalink
Clean up some includes/dependencies
Browse files Browse the repository at this point in the history
Reviewed By: astreet

Differential Revision: D2905196

fb-gh-sync-id: d92f0e0296f4877b589cac674e388a5dbabc7d71
shipit-source-id: d92f0e0296f4877b589cac674e388a5dbabc7d71
  • Loading branch information
cjhopman authored and facebook-github-bot-5 committed Feb 9, 2016
1 parent 48f82e4 commit d80ee0a
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 16 deletions.
3 changes: 0 additions & 3 deletions ReactAndroid/src/main/jni/react/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ include_defs('//ReactAndroid/DEFS')
SUPPORTED_PLATFORMS = '^android-(armv7|x86)$'

DEPS = [
'//native/fb:fb',
'//native/jni:jni',
'//native/third-party/android-ndk:android',
'//xplat/fbsystrace:fbsystrace',
'//xplat/folly:molly',
'//xplat/third-party/glog:glog',
Expand Down
11 changes: 5 additions & 6 deletions ReactAndroid/src/main/jni/react/JSCExecutor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,17 @@
#include <atomic>
#include <sstream>
#include <string>
#include <fb/log.h>
#include <folly/json.h>
#include <folly/String.h>
#include <sys/time.h>

#include "JSCHelpers.h"
#include "Value.h"
#include "jni/OnLoad.h"
#include <react/JSCHelpers.h>
#include "Platform.h"

#ifdef WITH_JSC_EXTRA_TRACING
#include <react/JSCTracing.h>
#include <react/JSCLegacyProfiler.h>
#include "JSCTracing.h"
#include "JSCLegacyProfiler.h"
#include <JavaScriptCore/API/JSProfilerPrivate.h>
#endif

Expand All @@ -31,7 +30,7 @@ using fbsystrace::FbSystraceSection;
#endif

#ifdef WITH_FB_MEMORY_PROFILING
#include <react/JSCMemory.h>
#include "JSCMemory.h"
#endif

#ifdef WITH_FB_JSC_TUNING
Expand Down
4 changes: 0 additions & 4 deletions ReactAndroid/src/main/jni/react/JSCWebWorker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,12 @@
#include <folly/Memory.h>

#include "JSCHelpers.h"
#include "jni/JSLoader.h"
#include "jni/WebWorkers.h"
#include "MessageQueueThread.h"
#include "Platform.h"
#include "Value.h"

#include <JavaScriptCore/JSValueRef.h>

using namespace facebook::jni;

namespace facebook {
namespace react {

Expand Down
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/jni/react/Value.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

#include "Value.h"

#include <jni/fbjni.h>

#include "JSCHelpers.h"

namespace facebook {
Expand Down
2 changes: 1 addition & 1 deletion ReactAndroid/src/main/jni/react/jni/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ jni_library(
'JniJSModulesUnbundle.h',
'JSCPerfLogging.h',
'JSLogging.h',
'WebWorkers.h',
],
exported_headers = [
'NativeArray.h',
'ReadableNativeArray.h',
'WebWorkers.h',
],
preprocessor_flags = [
'-DLOG_TAG="ReactNativeJNI"',
Expand Down

0 comments on commit d80ee0a

Please sign in to comment.