Skip to content

Commit

Permalink
Remove deprecated removeSubscription from the type of NativeEventEmit…
Browse files Browse the repository at this point in the history
…ter (#39115)

Summary:
Removed deprecated function removeSubscription from the type of NativeEventEmitter, so that it lines up with its implementation. This is a fix for #39111 .

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[General] [Fixed] - Fix a type issue of NativeEventEmitter

Pull Request resolved: #39115

Test Plan: Not applicable

Reviewed By: NickGerleman

Differential Revision: D48573676

Pulled By: lunaleaps

fbshipit-source-id: e70c951e230e0d236e0bf0a1ba02b450bdc98ac5
  • Loading branch information
Yupeng Li authored and facebook-github-bot committed Aug 22, 2023
1 parent 4f7cdd5 commit d4d323c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,4 @@ declare class NativeEventEmitter extends EventEmitter {
* @param eventType name of the event whose registered listeners to remove
*/
removeAllListeners(eventType: string): void;

/**
* Removes a subscription created by the addListener, the EventSubscription#remove()
* function actually calls through to this.
*/
removeSubscription(subscription: EmitterSubscription): void;
}
2 changes: 0 additions & 2 deletions packages/react-native/types/__typetests__/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,6 @@ const sub2 = androidEventEmitter.addListener(
androidEventEmitter.listenerCount('event'); // $ExpectType number
sub2.remove();
androidEventEmitter.removeAllListeners('event');
androidEventEmitter.removeSubscription(sub1);

// NativeEventEmitter - IOS
const nativeModule: NativeModule = {
Expand All @@ -1081,7 +1080,6 @@ const sub4 = iosEventEmitter.addListener('event', (event: object) => event, {});
iosEventEmitter.listenerCount('event');
sub4.remove();
iosEventEmitter.removeAllListeners('event');
iosEventEmitter.removeSubscription(sub3);

class CustomEventEmitter extends NativeEventEmitter {}

Expand Down

0 comments on commit d4d323c

Please sign in to comment.