Skip to content

Commit

Permalink
Debug only code were leaking into release builds on iOS. (#21232)
Browse files Browse the repository at this point in the history
Summary:
RCT_DEBUG is always defined - it is just rather 0 or 1 so
```#ifndef RCT_DEBUG is always true```
Pull Request resolved: #21232

Differential Revision: D9982316

Pulled By: hramos

fbshipit-source-id: 5408bfcf95a6ed2beae38217a6ad1ee43950857d
  • Loading branch information
dryganets authored and facebook-github-bot committed Sep 21, 2018
1 parent 40bcc38 commit d1ff0b0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion React/Base/RCTUtils.m
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,7 @@ static void RCTGetRGBAColorComponents(CGColorRef color, CGFloat rgba[4])
default:
{

#ifdef RCT_DEBUG
#if RCT_DEBUG
//unsupported format
RCTLogError(@"Unsupported color model: %i", model);
#endif
Expand Down
2 changes: 1 addition & 1 deletion React/CxxBridge/RCTCxxBridge.mm
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ - (void)installExtraJSBinding
NSArray<RCTModuleData *> *moduleDataById = [self registerModulesForClasses:modules];

if (lazilyDiscovered) {
#ifdef RCT_DEBUG
#if RCT_DEBUG
// Lazily discovered modules do not require instantiation here,
// as they are not allowed to have pre-instantiated instance
// and must not require the main queue.
Expand Down

0 comments on commit d1ff0b0

Please sign in to comment.