Skip to content

Commit

Permalink
reactRespondsToTouch: was removed
Browse files Browse the repository at this point in the history
Summary:
* It complicates Touch Handling mechanism.
* The same functionality can be (and should be) implemented via overriding standard `hitTest:` method.
* It was marked as deprecated a while ago.

Reviewed By: mmmulani

Differential Revision: D4667776

fbshipit-source-id: 2e047c3308563a2849ea351a242270f0800fead2
  • Loading branch information
shergin authored and facebook-github-bot committed Apr 10, 2017
1 parent 1d27008 commit ca6e0b3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 15 deletions.
3 changes: 1 addition & 2 deletions React/Base/RCTTouchHandler.m
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ - (void)_recordNewTouches:(NSSet<UITouch *> *)touches
// Find closest React-managed touchable view
UIView *targetView = touch.view;
while (targetView) {
if (targetView.reactTag && targetView.userInteractionEnabled &&
[targetView reactRespondsToTouch:touch]) {
if (targetView.reactTag && targetView.userInteractionEnabled) {
break;
}
targetView = targetView.superview;
Expand Down
5 changes: 0 additions & 5 deletions React/Views/UIView+React.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@
- (void)reactFocusIfNeeded;
- (void)reactBlur;

/**
* Responder overrides - to be deprecated.
*/
- (BOOL)reactRespondsToTouch:(UITouch *)touch;

#if RCT_DEV

/**
Expand Down
8 changes: 0 additions & 8 deletions React/Views/UIView+React.m
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,4 @@ - (void)reactBlur {
[self resignFirstResponder];
}

/**
* Responder overrides - to be deprecated.
*/
- (BOOL)reactRespondsToTouch:(__unused UITouch *)touch
{
return YES;
}

@end

0 comments on commit ca6e0b3

Please sign in to comment.