Skip to content

Commit

Permalink
Default scrollview to flexShrink to allow views below it
Browse files Browse the repository at this point in the history
Summary: Changing from flex -> flexGrow on Scrollview caused some layouts to break due to having views below the scrollview. Adding flexShrink allows for the behavior again.

Reviewed By: blairvanderhoof

Differential Revision: D3936963

fbshipit-source-id: 0f43e6f5148918d3d431b98d26d185bbcc1548d0
  • Loading branch information
Emil Sjolander authored and Facebook Github Bot 9 committed Sep 28, 2016
1 parent e083f9a commit c43a3f5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Libraries/Components/ScrollView/ScrollView.js
Original file line number Diff line number Diff line change
Expand Up @@ -546,11 +546,13 @@ const ScrollView = React.createClass({
const styles = StyleSheet.create({
baseVertical: {
flexGrow: 1,
flexShrink: 1,
flexDirection: 'column',
overflow: 'scroll',
},
baseHorizontal: {
flexGrow: 1,
flexShrink: 1,
flexDirection: 'row',
overflow: 'scroll',
},
Expand Down

0 comments on commit c43a3f5

Please sign in to comment.