Skip to content

Commit

Permalink
Pass accessibilityHint through Button component
Browse files Browse the repository at this point in the history
Summary:
Changelog: [Internal]

Previously, the `accessibilityHint` value isn't passed through the underlying component so that the voice over system doesn't announce it. This diff fixes that.

Reviewed By: sammy-SC

Differential Revision: D31017275

fbshipit-source-id: 1bf5a5e36fdfed2a199986b82684a40e18325ba1
  • Loading branch information
jimmy623 authored and facebook-github-bot committed Sep 18, 2021
1 parent 6c66cef commit be53728
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Libraries/Components/Button.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ type ButtonProps = $ReadOnly<{|
accessibilityActions?: ?$ReadOnlyArray<AccessibilityActionInfo>,
onAccessibilityAction?: ?(event: AccessibilityActionEvent) => mixed,
accessibilityState?: ?AccessibilityState,
accessibilityHint?: ?string,
|}>;

/**
Expand Down Expand Up @@ -275,6 +276,7 @@ class Button extends React.Component<ButtonProps> {
testID,
accessible,
accessibilityActions,
accessibilityHint,
onAccessibilityAction,
} = this.props;
const buttonStyles = [styles.button];
Expand Down Expand Up @@ -317,6 +319,7 @@ class Button extends React.Component<ButtonProps> {
accessibilityActions={accessibilityActions}
onAccessibilityAction={onAccessibilityAction}
accessibilityLabel={accessibilityLabel}
accessibilityHint={accessibilityHint}
accessibilityRole="button"
accessibilityState={accessibilityState}
hasTVPreferredFocus={hasTVPreferredFocus}
Expand Down

0 comments on commit be53728

Please sign in to comment.