Skip to content

Commit

Permalink
Refactor CXX Component classes
Browse files Browse the repository at this point in the history
Summary:
This diff is moving all relevant cxx component classes out of react-native-github, this is necessary to make it easy to iterate on their APIs
We will move them back again to OSS once we make the API stable

changelog: [internal] internal

Reviewed By: arhelmus

Differential Revision: D42018363

fbshipit-source-id: bacf0c667e2e8df57b4b57e257bf937586b8e6f7
  • Loading branch information
mdvacca authored and facebook-github-bot committed Dec 19, 2022
1 parent e193d1c commit b71b43a
Show file tree
Hide file tree
Showing 12 changed files with 1 addition and 326 deletions.
5 changes: 1 addition & 4 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,7 @@ final def preparePrefab = tasks.register("preparePrefab", PreparePrefabHeadersTa
),
new PrefabPreprocessingEntry(
"fabricjni",
[
new Pair("src/main/jni/react/fabric", "react/fabric/"),
new Pair("src/main/jni/react/cxxcomponents", "react/cxxcomponents/")
]
new Pair("src/main/jni/react/fabric", "react/fabric/")
),
new PrefabPreprocessingEntry(
"react_render_mapbuffer",
Expand Down
1 change: 0 additions & 1 deletion ReactAndroid/src/main/jni/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ add_react_build_subdir(generated/source/codegen/jni)
add_react_android_subdir(src/main/jni/first-party/fb)
add_react_android_subdir(src/main/jni/first-party/fbgloginit)
add_react_android_subdir(src/main/jni/first-party/yogajni)
add_react_android_subdir(src/main/jni/react/cxxcomponents)
add_react_android_subdir(src/main/jni/react/jni)
add_react_android_subdir(src/main/jni/react/reactperflogger)
add_react_android_subdir(src/main/jni/react/jscexecutor)
Expand Down
44 changes: 0 additions & 44 deletions ReactAndroid/src/main/jni/react/cxxcomponents/BUCK

This file was deleted.

22 changes: 0 additions & 22 deletions ReactAndroid/src/main/jni/react/cxxcomponents/CMakeLists.txt

This file was deleted.

48 changes: 0 additions & 48 deletions ReactAndroid/src/main/jni/react/cxxcomponents/Component.h

This file was deleted.

24 changes: 0 additions & 24 deletions ReactAndroid/src/main/jni/react/cxxcomponents/ComponentManager.h

This file was deleted.

1 change: 0 additions & 1 deletion ReactAndroid/src/main/jni/react/fabric/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ rn_xplat_cxx_library(
react_native_xplat_target("react/renderer/componentregistry:componentregistry"),
react_native_xplat_target("react/renderer/components/scrollview:scrollview"),
react_native_xplat_target("runtimeexecutor:runtimeexecutor"),
"//xplat/js/react-native-github/ReactAndroid/src/main/jni/react/cxxcomponents:components",
react_native_target("jni/react/jni:jni"),
"//xplat/fbsystrace:fbsystrace",
"//xplat/jsi:JSIDynamic",
Expand Down
1 change: 0 additions & 1 deletion ReactAndroid/src/main/jni/react/fabric/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ target_include_directories(fabricjni PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
target_link_libraries(
fabricjni
butter
cxxcomponents
fb
fbjni
folly_runtime
Expand Down

This file was deleted.

45 changes: 0 additions & 45 deletions ReactAndroid/src/main/jni/react/fabric/ComponentRegistryResolver.h

This file was deleted.

46 changes: 0 additions & 46 deletions ReactAndroid/src/main/jni/react/fabric/CppComponentRegistry.cpp

This file was deleted.

49 changes: 0 additions & 49 deletions ReactAndroid/src/main/jni/react/fabric/CppComponentRegistry.h

This file was deleted.

0 comments on commit b71b43a

Please sign in to comment.