-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Convert ReactMarkerConsts back to enum, use @CountEnum
Summary: Reverting D9304307 and also adding CountEnum annotation to ReactMarkerConstants. This way we get the typesafety of the enum with the optimization of converting to int in production builds. More on the count: https://our.intern.facebook.com/intern/wiki/Android-java-transforms/the-count/ Reviewed By: achen1 Differential Revision: D9623235 fbshipit-source-id: ab992e7edb6cf999f5f122faee31075a63782411
- Loading branch information
1 parent
917800c
commit b5d908b
Showing
3 changed files
with
108 additions
and
168 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ rn_android_library( | |
deps = [ | ||
react_native_dep("java/com/facebook/debug/debugoverlay/model:model"), | ||
react_native_dep("java/com/facebook/systrace:systrace"), | ||
react_native_dep("java/com/facebook/thecount:thecount"), | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
hramos
Contributor
|
||
react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"), | ||
react_native_dep("libraries/soloader/java/com/facebook/soloader:soloader"), | ||
react_native_dep("third-party/java/infer-annotations:infer-annotations"), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like miss the dependency in
build.gradle