[RN][0.74]Fix XROS build

facebook · Jul 23, 2024 · 96a1bb1 · 96a1bb1
1 parent c9ce048
commit 96a1bb1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/.circleci/configurations/executors.yml b/.circleci/configurations/executors.yml
@@ -39,7 +39,7 @@ executors:
   reactnativeios-lts:
     <<: *defaults
     macos:
-      xcode: '14.3.1'
+      xcode: '15.2'
     resource_class: macos.m1.medium.gen1
     environment:
       - RCT_BUILD_HERMES_FROM_SOURCE: true
diff --git a/.circleci/configurations/jobs.yml b/.circleci/configurations/jobs.yml
@@ -786,9 +786,6 @@ jobs:
       - HERMES_WS_DIR: *hermes_workspace_root
       - HERMES_TARBALL_ARTIFACTS_DIR: *hermes_tarball_artifacts_dir
       - HERMES_OSXBIN_ARTIFACTS_DIR: *hermes_osxbin_artifacts_dir
-      - IOS_DEPLOYMENT_TARGET: "13.4"
-      - XROS_DEPLOYMENT_TARGET: "1.0"
-      - MACOSX_DEPLOYMENT_TARGET: "10.15"
     steps:
       - *attach_hermes_workspace
       - stop_job_if_apple_artifacts_are_there:
@@ -824,6 +821,23 @@ jobs:
               echo "[HERMES] Building Hermes for iOS: $SLICE"
               BUILD_TYPE="<< parameters.flavor >>" ./utils/build-ios-framework.sh "$SLICE"
             fi
+
+            if [[ "$SLICE" == "macosx" ]]; then
+              export MACOSX_DEPLOYMENT_TARGET="10.15"
+              echo "[HERMES] Building Hermes for MacOS"
+              BUILD_TYPE="<< parameters.flavor >>" ./utils/build-mac-framework.sh
+              unset MACOSX_DEPLOYMENT_TARGET
+            elif [[ "$SLICE" == "xros" ]] || [[ "$SLICE" == "xrsimulator" ]]; then
+              export XROS_DEPLOYMENT_TARGET="1.0"
+              echo "[HERMES] Building Hermes for XR: $SLICE"
+              BUILD_TYPE="<< parameters.flavor >>" ./utils/build-ios-framework.sh "$SLICE"
+              unset XROS_DEPLOYMENT_TARGET
+            elif [[ "$SLICE" == "iphoneos" ]] || [[ "$SLICE" == "iphonesimulator" ]] || [[ "$SLICE" == "catalyst" ]] ; then
+              export IOS_DEPLOYMENT_TARGET="13.4"
+              echo "[HERMES] Building Hermes for iOS: $SLICE"
+              BUILD_TYPE="<< parameters.flavor >>" ./utils/build-ios-framework.sh "$SLICE"
+              unset IOS_DEPLOYMENT_TARGET
+            fi
             unset RELEASE_VERSION
 
             echo "Moving from build_$SLICE to $FINAL_PATH"