Skip to content

Commit

Permalink
Update usages of default ReactNativeConfig (#33196)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #33196

Fixes compilation of Android template and renames the field according to Java guidelines.

Changelog: [Android][Changed] - Rename field with default values for ReactConfig to DEFAULT_CONFIG

Reviewed By: cortinico

Differential Revision: D34523356

fbshipit-source-id: 46ed703e7ca8ab5e05879dd93e8e4d2d816c2d03
  • Loading branch information
Andrei Shikov authored and facebook-github-bot committed Feb 28, 2022
1 parent 75348ac commit 964e816
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
@DoNotStrip
public interface ReactNativeConfig {

public final ReactNativeConfig DefaultValuesReactNativeConfig = new EmptyReactNativeConfig();
ReactNativeConfig DEFAULT_CONFIG = new EmptyReactNativeConfig();

/**
* Get a boolean param by string name. Default should be false.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public JSIModuleProvider<UIManager> getJSIModuleProvider() {
return new FabricJSIModuleProvider(
reactApplicationContext,
componentFactory,
ReactNativeConfig.DefaultValuesReactNativeConfig,
ReactNativeConfig.DEFAULT_CONFIG,
viewManagerRegistry);
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.facebook.react.fabric.ComponentFactory;
import com.facebook.react.fabric.CoreComponentsRegistry;
import com.facebook.react.fabric.FabricJSIModuleProvider;
import com.facebook.react.fabric.ReactNativeConfig;
import com.facebook.react.uimanager.ViewManagerRegistry;
import com.helloworld.BuildConfig;
import com.helloworld.newarchitecture.components.MainComponentsRegistry;
Expand Down Expand Up @@ -104,7 +105,7 @@ public JSIModuleProvider<UIManager> getJSIModuleProvider() {
return new FabricJSIModuleProvider(
reactApplicationContext,
componentFactory,
ReactNativeConfig.DefaultValuesReactNativeConfig,
ReactNativeConfig.DEFAULT_CONFIG,
viewManagerRegistry);
}
});
Expand Down

0 comments on commit 964e816

Please sign in to comment.