Upgrade fbsource/xplat/js to Flow v0.53.0

Reviewed By: avikchaudhuri Differential Revision: D5648819 Ninja: T20988071 fbshipit-source-id: 66e5b6747c79ae66b6eb69d40ede5e982c26174f
facebook · Aug 18, 2017 · 90eaeb0 · janicduplessis · Aug 22, 2017 · janicduplessis
1 parent 1ce7e4c
commit 90eaeb0
Show file tree

Hide file tree

Showing 154 changed files with 652 additions and 631 deletions.
diff --git a/.flowconfig b/.flowconfig
@@ -42,14 +42,16 @@ module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|we
 
 suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
+suppress_type=$FlowFixMeProps
+suppress_type=$FlowFixMeState
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-2]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-2]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-3]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-3]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.52.0
+^0.53.0
diff --git a/IntegrationTests/AccessibilityManagerTest.js b/IntegrationTests/AccessibilityManagerTest.js
@@ -21,7 +21,7 @@ const {
 } = ReactNative.NativeModules;
 
 
-class AccessibilityManagerTest extends React.Component {
+class AccessibilityManagerTest extends React.Component<{}> {
   componentDidMount() {
     AccessibilityManager.setAccessibilityContentSizeMultipliers({
       'extraSmall': 1.0,
@@ -42,7 +42,7 @@ class AccessibilityManagerTest extends React.Component {
     });
   }
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/AppEventsTest.js b/IntegrationTests/AppEventsTest.js
@@ -32,7 +32,7 @@ type State = {
   elapsed?: string,
 };
 
-class AppEventsTest extends React.Component {
+class AppEventsTest extends React.Component<{}, State> {
   state: State = {sent: 'none', received: 'none'};
 
   componentDidMount() {

diff --git a/IntegrationTests/AsyncStorageTest.js b/IntegrationTests/AsyncStorageTest.js
@@ -168,7 +168,7 @@ function testOptimizedMultiGet() {
 }
 
 
-class AsyncStorageTest extends React.Component {
+class AsyncStorageTest extends React.Component<{}, $FlowFixMeState> {
   state = {
     messages: 'Initializing...',
     done: false,

diff --git a/IntegrationTests/ImageCachePolicyTest.js b/IntegrationTests/ImageCachePolicyTest.js
@@ -41,7 +41,7 @@ type State = {
   'force-cache'?: boolean,
 }
 
-class ImageCachePolicyTest extends React.Component {
+class ImageCachePolicyTest extends React.Component<Props, $FlowFixMeState> {
   state = {}
 
   shouldComponentUpdate(nextProps: Props, nextState: State) {

diff --git a/IntegrationTests/ImageSnapshotTest.js b/IntegrationTests/ImageSnapshotTest.js
@@ -19,7 +19,7 @@ var {
 } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class ImageSnapshotTest extends React.Component {
+class ImageSnapshotTest extends React.Component<{}> {
   componentDidMount() {
     if (!TestModule.verifySnapshot) {
       throw new Error('TestModule.verifySnapshot not defined.');

diff --git a/IntegrationTests/IntegrationTestHarnessTest.js b/IntegrationTests/IntegrationTestHarnessTest.js
@@ -21,12 +21,10 @@ var {
 } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class IntegrationTestHarnessTest extends React.Component {
-  props: {
-    shouldThrow?: boolean,
-    waitOneFrame?: boolean,
-  };
-
+class IntegrationTestHarnessTest extends React.Component<{
+  shouldThrow?: boolean,
+  waitOneFrame?: boolean,
+}, $FlowFixMeState> {
   static propTypes = {
     shouldThrow: PropTypes.bool,
     waitOneFrame: PropTypes.bool,

diff --git a/IntegrationTests/IntegrationTestsApp.js b/IntegrationTests/IntegrationTestsApp.js
@@ -48,7 +48,7 @@ require('LoggingTestModule');
 
 type Test = any;
 
-class IntegrationTestsApp extends React.Component {
+class IntegrationTestsApp extends React.Component<{}, $FlowFixMeState> {
   state = {
     test: (null: ?Test),
   };
@@ -57,6 +57,10 @@ class IntegrationTestsApp extends React.Component {
     if (this.state.test) {
       return (
         <ScrollView>
+          {/* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses
+            * an error when upgrading Flow's support for React. Common errors
+            * found when upgrading Flow's React support are documented at
+            * https://fburl.com/eq7bs81w */}
           <this.state.test />
         </ScrollView>
       );

diff --git a/IntegrationTests/PromiseTest.js b/IntegrationTests/PromiseTest.js
@@ -16,7 +16,7 @@ var ReactNative = require('react-native');
 var { View } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class PromiseTest extends React.Component {
+class PromiseTest extends React.Component<{}> {
   shouldResolve = false;
   shouldReject = false;
   shouldSucceedAsync = false;
@@ -66,7 +66,7 @@ class PromiseTest extends React.Component {
     }
   };
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/SimpleSnapshotTest.js b/IntegrationTests/SimpleSnapshotTest.js
@@ -21,7 +21,7 @@ var {
 } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class SimpleSnapshotTest extends React.Component {
+class SimpleSnapshotTest extends React.Component<{}> {
   componentDidMount() {
     if (!TestModule.verifySnapshot) {
       throw new Error('TestModule.verifySnapshot not defined.');

diff --git a/IntegrationTests/SyncMethodTest.js b/IntegrationTests/SyncMethodTest.js
@@ -21,7 +21,7 @@ const {
 } = ReactNative.NativeModules;
 
 
-class SyncMethodTest extends React.Component {
+class SyncMethodTest extends React.Component<{}> {
   componentDidMount() {
     if (RNTesterTestModule.echoString('test string value') !== 'test string value') {
       throw new Error('Something wrong with sync method export');
@@ -32,7 +32,7 @@ class SyncMethodTest extends React.Component {
     TestModule.markTestCompleted();
   }
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/WebSocketTest.js b/IntegrationTests/WebSocketTest.js
@@ -42,7 +42,7 @@ type State = {
   testExpectedResponse: string;
 };
 
-class WebSocketTest extends React.Component {
+class WebSocketTest extends React.Component<{}, State> {
   state: State = {
     url: DEFAULT_WS_URL,
     fetchStatus: null,
@@ -158,7 +158,7 @@ class WebSocketTest extends React.Component {
     });
   }
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/Libraries/Animated/src/AnimatedImplementation.js b/Libraries/Animated/src/AnimatedImplementation.js
@@ -1753,7 +1753,7 @@ class AnimatedProps extends Animated {
 }
 
 function createAnimatedComponent(Component: any): any {
-  class AnimatedComponent extends React.Component {
+  class AnimatedComponent extends React.Component<Object> {
     _component: any;
     _prevComponent: any;
     _propsAnimated: AnimatedProps;

diff --git a/Libraries/Components/Button.js b/Libraries/Components/Button.js
@@ -48,17 +48,14 @@ const invariant = require('fbjs/lib/invariant');
  *
  */
 
-class Button extends React.Component {
-
-  props: {
-    title: string,
-    onPress: () => any,
-    color?: ?string,
-    accessibilityLabel?: ?string,
-    disabled?: ?boolean,
-    testID?: ?string,
-  };
-
+class Button extends React.Component<{
+  title: string,
+  onPress: () => any,
+  color?: ?string,
+  accessibilityLabel?: ?string,
+  disabled?: ?boolean,
+  testID?: ?string,
+}> {
   static propTypes = {
     /**
      * Text to display inside the button

diff --git a/Libraries/Components/MaskedView/MaskedViewIOS.ios.js b/Libraries/Components/MaskedView/MaskedViewIOS.ios.js
@@ -25,7 +25,7 @@ type Props = ViewProps & {
    * Should be a React element to be rendered and applied as the
    * mask for the child element.
    */
-  maskElement: React.Element<*>,
+  maskElement: React.Element<any>,
 };
 
 /**
@@ -64,9 +64,7 @@ type Props = ViewProps & {
  * transparent pixels block that content.
  *
  */
-class MaskedViewIOS extends React.Component {
-  props: Props;
-
+class MaskedViewIOS extends React.Component<Props> {
   static propTypes = {
     ...ViewPropTypes,
     maskElement: PropTypes.element.isRequired,

diff --git a/Libraries/Components/Navigation/NavigatorIOS.ios.js b/Libraries/Components/Navigation/NavigatorIOS.ios.js
@@ -36,7 +36,7 @@ function getuid() {
   return __uid++;
 }
 
-class NavigatorTransitionerIOS extends React.Component {
+class NavigatorTransitionerIOS extends React.Component<$FlowFixMeProps> {
   requestSchedulingNavigation(cb) {
     RCTNavigatorManager.requestSchedulingJavaScriptNavigation(
       ReactNative.findNodeHandle(this),

diff --git a/Libraries/Components/Picker/Picker.js b/Libraries/Components/Picker/Picker.js
@@ -37,14 +37,12 @@ var MODE_DROPDOWN = 'dropdown';
 /**
  * Individual selectable item in a Picker.
  */
-class PickerItem extends React.Component {
- props: {
-  label: string,
-  value?: any,
-  color?: ColorPropType,
-  testID?: string,
- };
-
+class PickerItem extends React.Component<{
+ label: string,
+ value?: any,
+ color?: ColorPropType,
+ testID?: string,
+}> {
  static propTypes = {
    /**
     * Text to display for this item.
@@ -82,18 +80,16 @@ class PickerItem extends React.Component {
  *       <Picker.Item label="JavaScript" value="js" />
  *     </Picker>
  */
-class Picker extends React.Component {
- props: {
-  style?: $FlowFixMe,
-  selectedValue?: any,
-  onValueChange?: Function,
-  enabled?: boolean,
-  mode?: 'dialog' | 'dropdown',
-  itemStyle?: $FlowFixMe,
-  prompt?: string,
-  testID?: string,
- };
-
+class Picker extends React.Component<{
+ style?: $FlowFixMe,
+ selectedValue?: any,
+ onValueChange?: Function,
+ enabled?: boolean,
+ mode?: 'dialog' | 'dropdown',
+ itemStyle?: $FlowFixMe,
+ prompt?: string,
+ testID?: string,
+}> {
  /**
   * On Android, display the options in a dialog.
   */

diff --git a/Libraries/Components/Picker/PickerAndroid.android.js b/Libraries/Components/Picker/PickerAndroid.android.js
@@ -36,19 +36,15 @@ type Event = Object;
 /**
  * Not exposed as a public API - use <Picker> instead.
  */
-class PickerAndroid extends React.Component {
-  props: {
-    style?: $FlowFixMe,
-    selectedValue?: any,
-    enabled?: boolean,
-    mode?: 'dialog' | 'dropdown',
-    onValueChange?: Function,
-    prompt?: string,
-    testID?: string,
-  };
-
-  state: *;
-
+class PickerAndroid extends React.Component<{
+  style?: $FlowFixMe,
+  selectedValue?: any,
+  enabled?: boolean,
+  mode?: 'dialog' | 'dropdown',
+  onValueChange?: Function,
+  prompt?: string,
+  testID?: string,
+}, *> {
   static propTypes = {
     ...ViewPropTypes,
     style: pickerStyleType,

diff --git a/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js b/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js
@@ -16,7 +16,7 @@ const requireNativeComponent = require('requireNativeComponent');
 
 const RCTRefreshControl = requireNativeComponent('RCTRefreshControl');
 
-class RefreshControlMock extends React.Component {
+class RefreshControlMock extends React.Component<{}> {
   static latestRef: ?RefreshControlMock;
   componentDidMount() {
     RefreshControlMock.latestRef = this;

diff --git a/Libraries/Components/ScrollView/ScrollView.js b/Libraries/Components/ScrollView/ScrollView.js
@@ -742,6 +742,10 @@ const ScrollView = createReactClass({
     const contentContainer =
       <ScrollContentContainerViewClass
         {...contentSizeChangeProps}
+        /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an
+         * error when upgrading Flow's support for React. Common errors found
+         * when upgrading Flow's React support are documented at
+         * https://fburl.com/eq7bs81w */
         ref={this._setInnerViewRef}
         style={contentContainerStyle}
         removeClippedSubviews={
@@ -814,6 +818,10 @@ const ScrollView = createReactClass({
         // On iOS the RefreshControl is a child of the ScrollView.
         // tvOS lacks native support for RefreshControl, so don't include it in that case
         return (
+          /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses
+           * an error when upgrading Flow's support for React. Common errors
+           * found when upgrading Flow's React support are documented at
+           * https://fburl.com/eq7bs81w */
           <ScrollViewClass {...props} ref={this._setScrollViewRef}>
             {Platform.isTVOS ? null : refreshControl}
             {contentContainer}
@@ -829,13 +837,21 @@ const ScrollView = createReactClass({
         return React.cloneElement(
           refreshControl,
           {style: props.style},
+          /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses
+           * an error when upgrading Flow's support for React. Common errors
+           * found when upgrading Flow's React support are documented at
+           * https://fburl.com/eq7bs81w */
           <ScrollViewClass {...props} style={baseStyle} ref={this._setScrollViewRef}>
             {contentContainer}
           </ScrollViewClass>
         );
       }
     }
     return (
+      /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an
+       * error when upgrading Flow's support for React. Common errors found
+       * when upgrading Flow's React support are documented at
+       * https://fburl.com/eq7bs81w */
       <ScrollViewClass {...props} ref={this._setScrollViewRef}>
         {contentContainer}
       </ScrollViewClass>
@@ -874,12 +890,12 @@ if (Platform.OS === 'android') {
   };
   AndroidScrollView = requireNativeComponent(
     'RCTScrollView',
-    (ScrollView: ReactClass<any>),
+    (ScrollView: React.ComponentType<any>),
     nativeOnlyProps
   );
   AndroidHorizontalScrollView = requireNativeComponent(
     'AndroidHorizontalScrollView',
-    (ScrollView: ReactClass<any>),
+    (ScrollView: React.ComponentType<any>),
     nativeOnlyProps
   );
 } else if (Platform.OS === 'ios') {
@@ -893,7 +909,7 @@ if (Platform.OS === 'android') {
   };
   RCTScrollView = requireNativeComponent(
     'RCTScrollView',
-    (ScrollView: ReactClass<any>),
+    (ScrollView: React.ComponentType<any>),
     nativeOnlyProps,
   );
   // $FlowFixMe (bvaughn) Update ComponentInterface in ViewPropTypes to include a string type (for Fiber host components) in a follow-up.