Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Text] Set LayoutParams in ReactTextView to fix crash
ReactTextView occasionally crashes when `setText` is called. Doing some cursory research, it looks like this could be a bug in Android. We also suspect it might be related to removeClippedSubviews though. The LayoutParams don't actually matter because RN controls layout, but on occasion (haven't narrowed down what this is...) `mLayout` is non-null and triggers relayout during `setText`, which fails because the LayoutParams are null. Stack trace: http://pastebin.com/P8VbxvPz Test Plan: Run an Android app that was sporadically crashing with the stack trace linked above. With this patch the crashes appear to have disappeared and the app is performing fine.
- Loading branch information