Skip to content

Commit

Permalink
Get ReactiveNative compiled with Clang 10 (#28362)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #28362

Fixed a few compilation errors emitted by Clang 10.

Changelog:
[iOS] [Fixed] - Get ready for Clang 10

Differential Revision: D20549970

fbshipit-source-id: dc36a85d90d3e43a05f045feb57c6ab6ded67da7
  • Loading branch information
maxovtsin authored and facebook-github-bot committed Mar 23, 2020
1 parent 0952e4b commit 8721ee0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion React/CxxBridge/RCTCxxBridge.mm
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ - (void)registerExtraLazyModules
#endif
}

- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules
- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<Class> *)modules
withDispatchGroup:(dispatch_group_t)dispatchGroup
lazilyDiscovered:(BOOL)lazilyDiscovered
{
Expand Down
1 change: 1 addition & 0 deletions ReactCommon/fabric/graphics/platform/ios/Color.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

#include "Color.h"
#include <cassert>

namespace facebook {
namespace react {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ - (void)notifyAboutTurboModuleSetup:(const char *)name
@"%@ has no setter or ivar for its bridge, which is not "
"permitted. You must either @synthesize the bridge property, "
"or provide your own setter method.",
RCTBridgeModuleNameForClass(strongModule));
RCTBridgeModuleNameForClass([strongModule class]));
}

[performanceLogger attachRCTBridgeToRCTTurboModuleEnd:moduleName];
Expand Down

0 comments on commit 8721ee0

Please sign in to comment.