Delete ReactInstancePackage (#41095)

Summary: Pull Request resolved: #41095 I'm deleting this class becase ReactInstancePackage has been deprecated since 2018 and I analyzed internal meta codebase and OSS codebase and it seems it's not being used. changelog: [Android][Breaking] Delete ReactInstancePackage Reviewed By: philIip Differential Revision: D50338299 fbshipit-source-id: 2824e58ff3bf9d17b605239dd9c9bea0adba93b8
facebook · Oct 31, 2023 · 7141c47 · 7141c47
1 parent 5a57ec8
commit 7141c47
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 50 deletions.
diff --git a/...act-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.java b/...act-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.java
@@ -39,8 +39,7 @@ public void processPackage(ReactPackage reactPackage) {
           ((BaseReactPackage) reactPackage).getNativeModuleIterator(mReactApplicationContext);
     } else {
       moduleHolders =
-          ReactPackageHelper.getNativeModuleIterator(
-              reactPackage, mReactApplicationContext, mReactInstanceManager);
+          ReactPackageHelper.getNativeModuleIterator(reactPackage, mReactApplicationContext);
     }
 
     for (ModuleHolder moduleHolder : moduleHolders) {

diff --git a/...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstancePackage.java b/...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstancePackage.java
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java
@@ -26,21 +26,13 @@ class ReactPackageHelper {
    */
   /** package */
   static Iterable<ModuleHolder> getNativeModuleIterator(
-      ReactPackage reactPackage,
-      ReactApplicationContext reactApplicationContext,
-      ReactInstanceManager reactInstanceManager) {
+      ReactPackage reactPackage, ReactApplicationContext reactApplicationContext) {
     FLog.d(
         ReactConstants.TAG,
         reactPackage.getClass().getSimpleName()
             + " is not a LazyReactPackage, falling back to old version.");
-    final List<NativeModule> nativeModules;
-    if (reactPackage instanceof ReactInstancePackage) {
-      ReactInstancePackage reactInstancePackage = (ReactInstancePackage) reactPackage;
-      nativeModules =
-          reactInstancePackage.createNativeModules(reactApplicationContext, reactInstanceManager);
-    } else {
-      nativeModules = reactPackage.createNativeModules(reactApplicationContext);
-    }
+    final List<NativeModule> nativeModules =
+        reactPackage.createNativeModules(reactApplicationContext);
     return () ->
         new Iterator<ModuleHolder>() {
           int position = 0;

diff --git a/...ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java b/...ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java
@@ -85,11 +85,6 @@ protected ReactPackageTurboModuleManagerDelegate(
         continue;
       }
 
-      if (shouldSupportLegacyPackages() && reactPackage instanceof ReactInstancePackage) {
-        // TODO(T145105887): Output error that ReactPackage was used
-        continue;
-      }
-
       if (shouldSupportLegacyPackages()) {
         // TODO(T145105887): Output warnings that ReactPackage was used
         final List<NativeModule> nativeModules =