Skip to content

Commit

Permalink
Fix bug where we used border box for size of containing block in a ce…
Browse files Browse the repository at this point in the history
…rtain case (#41688)

Summary:
X-link: facebook/yoga#1486

Pull Request resolved: #41688

Somehow missed this case. We never want to measure the CB as that gets border box but we want padding box

Reviewed By: NickGerleman

Differential Revision: D51376309

fbshipit-source-id: 2b5119c421ef92fadb28a70254cb7fe02aeb8c28
  • Loading branch information
joevilches authored and facebook-github-bot committed Dec 8, 2023
1 parent ea3dd6b commit 5b05c79
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,7 @@ static void positionAbsoluteChildImpl(
// necessary.
if (child->isInlineStartPositionDefined(axis, direction)) {
const float positionRelativeToInlineStart =
child->getInlineStartPosition(
axis,
direction,
containingNode->getLayout().measuredDimension(dimension(axis))) +
child->getInlineStartPosition(axis, direction, containingBlockSize) +
containingNode->getInlineStartBorder(axis, direction) +
child->getInlineStartMargin(axis, direction, containingBlockSize);
const float positionRelativeToFlexStart =
Expand Down

0 comments on commit 5b05c79

Please sign in to comment.