Skip to content

Commit

Permalink
Move pointerEvents from formsStacking -> formsView
Browse files Browse the repository at this point in the history
Summary:
This was a bug, we are fixing it.

Move pointerEvents from formsStacking -> formsView and we are also removing "onLayout" from formsStackingContext

changelog: [internal] internal

Reviewed By: sammy-SC

Differential Revision: D33846660

fbshipit-source-id: 6b65a9a7815972e34dafbc48b3d732d9b02d5e9f
  • Loading branch information
mdvacca authored and facebook-github-bot committed Jan 28, 2022
1 parent ea74c57 commit 4b7face
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions ReactCommon/react/renderer/components/view/ViewShadowNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ void ViewShadowNode::initialize() noexcept {

bool formsStackingContext = !viewProps.collapsable ||
viewProps.pointerEvents == PointerEventsMode::None ||
viewProps.onLayout || viewProps.pointerEnter || viewProps.pointerLeave ||
viewProps.pointerMove || !viewProps.nativeId.empty() ||
viewProps.accessible || viewProps.opacity != 1.0 ||
viewProps.transform != Transform{} || viewProps.elevation != 0 ||
!viewProps.nativeId.empty() || viewProps.accessible ||
viewProps.opacity != 1.0 || viewProps.transform != Transform{} ||
viewProps.elevation != 0 ||
(viewProps.zIndex.has_value() &&
viewProps.yogaStyle.positionType() != YGPositionTypeStatic) ||
viewProps.yogaStyle.display() == YGDisplayNone ||
Expand All @@ -49,7 +48,8 @@ void ViewShadowNode::initialize() noexcept {

bool formsView = formsStackingContext ||
isColorMeaningful(viewProps.backgroundColor) ||
isColorMeaningful(viewProps.foregroundColor) ||
isColorMeaningful(viewProps.foregroundColor) || viewProps.pointerEnter ||
viewProps.pointerLeave || viewProps.pointerMove ||
!(viewProps.yogaStyle.border() == YGStyle::Edges{}) ||
!viewProps.testId.empty();

Expand Down

0 comments on commit 4b7face

Please sign in to comment.