Skip to content

Commit

Permalink
Rename StyleProp to DangerouslyImpreciseStyleProp
Browse files Browse the repository at this point in the history
Summary:
We want to rename these types to be more clear what they are actually for. I did this with a find and replace:

```
import type {StyleProp} from 'StyleSheet';
```

to

```
import type {DangerouslyImpreciseStyleProp} from 'StyleSheet';
```

and `StyleProp` to `DangerouslyImpreciseStyleProp`.

Reviewed By: yungsters

Differential Revision: D7178609

fbshipit-source-id: 32952e0c3a8b6aceef306f1f3c18844feb18f1aa
  • Loading branch information
elicwhite authored and facebook-github-bot committed Mar 7, 2018
1 parent ee26d9b commit 49ffc9f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Libraries/StyleSheet/StyleSheet.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import type {
LayoutStyle
} from 'StyleSheetTypes';

export type StyleProp = StyleObj;
export type DangerouslyImpreciseStyleProp = StyleObj;
export type Styles = _Styles;
export type StyleSheetStyle = _StyleSheetStyle;
type StyleSheet<+S: Styles> = $ObjMap<S, (Object) => StyleSheetStyle>;
Expand Down Expand Up @@ -136,7 +136,7 @@ module.exports = {
* array, saving allocations and maintaining reference equality for
* PureComponent checks.
*/
compose(style1: ?StyleProp, style2: ?StyleProp): ?StyleProp {
compose(style1: ?DangerouslyImpreciseStyleProp, style2: ?DangerouslyImpreciseStyleProp): ?DangerouslyImpreciseStyleProp {
if (style1 != null && style2 != null) {
return [style1, style2];
} else {
Expand Down

0 comments on commit 49ffc9f

Please sign in to comment.