Handle invalidation error in RCTObjcExecutor

Differential Revision: D6748200 fbshipit-source-id: eb98782c2ba080273c1f027846984f5f4caddf26
facebook · Jan 18, 2018 · 493f3e8 · 493f3e8 · aleclarson · Jan 28, 2019
1 parent 65184ec
commit 493f3e8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/React/CxxBridge/RCTObjcExecutor.mm b/React/CxxBridge/RCTObjcExecutor.mm
@@ -45,7 +45,10 @@
   {
     m_jsCallback = ^(id json, NSError *error) {
       if (error) {
-        m_errorBlock(error);
+        // Do not use "m_errorBlock" here as the bridge might be in the middle
+        // of invalidation as a result of error handling and "this" can be
+        // already deallocated.
+        errorBlock(error);
         return;
       }