Skip to content

Commit

Permalink
Make sure js bundle still exists at bundle-output path (#30149)
Browse files Browse the repository at this point in the history
Summary:
Since changes to support hermes on iOS the js bundled is moved away from the location where it is generated when calling metro. This causes issues with the RN sentry integration since it relies on intercepting this path to find the bundle file after running react-native-xcode.sh. Seems kind of like a hacky way to get the bundle location, but let's avoid breaking it.

https://github.com/getsentry/sentry-cli/blob/master/src/commands/react_native_xcode.rs

## Changelog

[iOS] [Fixed] - Make sure js bundle still exists at bundle-output path

Pull Request resolved: #30149

Test Plan:
Checked that the bundle file exists both at bundle-output path and in the .app.
Checked that the sentry release script works.

Reviewed By: cpojer

Differential Revision: D24480115

Pulled By: appden

fbshipit-source-id: c01c80d47ed54319f97063ec635c021552a95c22
  • Loading branch information
janicduplessis authored and facebook-github-bot committed Oct 23, 2020
1 parent bfbd841 commit 3a41f69
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/react-native-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ fi
$EXTRA_PACKAGER_ARGS

if [[ $USE_HERMES != true ]]; then
mv "$BUNDLE_FILE" "$DEST/"
cp "$BUNDLE_FILE" "$DEST/"
BUNDLE_FILE="$DEST/main.jsbundle"
else
EXTRA_COMPILER_ARGS=
Expand Down

0 comments on commit 3a41f69

Please sign in to comment.