Skip to content

Commit

Permalink
[LOCAL] Bump Podfile.lock and try to fix Hermes update
Browse files Browse the repository at this point in the history
  • Loading branch information
cipolleschi committed Jan 4, 2024
1 parent f63a721 commit 34da087
Show file tree
Hide file tree
Showing 3 changed files with 465 additions and 470 deletions.
2 changes: 1 addition & 1 deletion packages/react-native/scripts/cocoapods/helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def self.find_codegen_file(path)
module Helpers
class Constants
def self.min_ios_version_supported
return '12.4'
return '13.4'

This comment has been minimized.

Copy link
@RWanDev

RWanDev Jan 9, 2024

@cipolleschi 0.72 not compatible with 12.4 anymore ?

This comment has been minimized.

Copy link
@cipolleschi

cipolleschi Jan 9, 2024

Author Contributor

Ouch, it should be. There are no changes that pushes React Native not be compatible, if not this one.
I think I change this line to silence some Xcode warnings and then I actually committed it. 🤦

end
end
end
6 changes: 1 addition & 5 deletions packages/react-native/scripts/cocoapods/jsengine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,8 @@ def setup_hermes!(react_native_path: "../node_modules/react-native", fabric_enab
abort unless prep_status == 0

pod 'React-jsi', :path => "#{react_native_path}/ReactCommon/jsi"
# This `:tag => hermestag` below is only to tell CocoaPods to update hermes-engine when React Native version changes.
# We have custom logic to compute the source for hermes-engine. See sdks/hermes-engine/*
hermestag_file = File.join(react_native_dir, "sdks", ".hermesversion")
hermestag = File.exist?(hermestag_file) ? File.read(hermestag_file).strip : ''

pod 'hermes-engine', :podspec => "#{react_native_path}/sdks/hermes-engine/hermes-engine.podspec", :tag => hermestag
pod 'hermes-engine', :podspec => "#{react_native_path}/sdks/hermes-engine/hermes-engine.podspec"
pod 'React-hermes', :path => "#{react_native_path}/ReactCommon/hermes"
pod 'libevent', '~> 2.1.12'
end
Loading

0 comments on commit 34da087

Please sign in to comment.