Skip to content

Commit

Permalink
Log status code when commands fail (#48222)
Browse files Browse the repository at this point in the history
Summary:

Changelog: [internal]

Tiny improvement over the current setup so it might help detect some current issues.

Reviewed By: yungsters

Differential Revision: D67021976
  • Loading branch information
rubennorte authored and facebook-github-bot committed Dec 13, 2024
1 parent 06751aa commit 139ad79
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions packages/react-native-fantom/runner/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,21 @@ export function runBuck2(args: Array<string>): SpawnResultWithOriginalCommand {
export function getDebugInfoFromCommandResult(
commandResult: SpawnResultWithOriginalCommand,
): string {
const maybeSignal =
commandResult.signal != null ? `, signal: ${commandResult.signal}` : '';
const resultByStatus =
commandResult.status === 0
? 'succeeded'
: `failed (status code: ${commandResult.status}${maybeSignal})`;

const logLines = [
`Command ${commandResult.status === 0 ? 'succeeded' : 'failed'}: ${commandResult.originalCommand}`,
`Command ${resultByStatus}: ${commandResult.originalCommand}`,
'',
'stdout:',
commandResult.stdout,
commandResult.stdout || '(empty)',
'',
'stderr:',
commandResult.stderr,
commandResult.stderr || '(empty)',
];

if (commandResult.error) {
Expand Down

0 comments on commit 139ad79

Please sign in to comment.