-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reviewed By: martinbigio Differential Revision: D4579114 fbshipit-source-id: a2e9f634748e1c56eb9867bfb9e3e66e9cdc5e93
- Loading branch information
1 parent
3148cc0
commit 118e883
Showing
2 changed files
with
49 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118e883
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gaearon, I will need to revert this commit to get Master building again and this PR breaks the website build. Please fix the issues that happen when you run
build/generate.js
fromwebsite
folder.118e883
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining. I don't think reverting it is appropriate because it fixes the product builds. If there is a mistake in a website script, then we should fix the website script instead of reverting a product fix that blocks FB developers.
I'm going to take a look at the website script, but so far I don't see a
build
folder inwebsite
.118e883
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce this by running
node server/generate.js
in thewebsite
folder.Investigating.