Skip to content

Commit

Permalink
Unblock CI by disabling integration testing for test_ios_unit_hermes (
Browse files Browse the repository at this point in the history
#33128)

Summary:
I'm disabling the integration test step for `test_ios_unit_hermes` as they're currently failign wiht a
`SIGSEGV` introduced by 9010bfe

The change is legit, but is introducing an ABI incompatibility that is making the app crash at runtime.
We can re-enable them as soon as Hermes 0.12.0 is released.

## Changelog

[Internal] - Unblock CI by disabling integration testing for `test_ios_unit_hermes`

Pull Request resolved: #33128

Test Plan: Will wait for a Circle CI green before merging

Reviewed By: neildhar

Differential Revision: D34285751

Pulled By: cortinico

fbshipit-source-id: 40f8e3d1b41fc4d5f0459003dcd19d651aefbeb7
  • Loading branch information
cortinico authored and facebook-github-bot committed Feb 16, 2022
1 parent b2e625a commit 062c1f7
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,10 @@ workflows:
- test_ios:
name: test_ios_unit_hermes
use_hermes: true
run_unit_tests: true
# TODO(ncor, neildhar) Integration tests for iOS + Hermes are currently
# disabled due to an ABI incompatibility introduced by D33830544.
# They can be re-enabled as soon as Hermes 0.12.0 is released.
run_unit_tests: false
filters:
branches:
ignore: gh-pages
Expand Down

0 comments on commit 062c1f7

Please sign in to comment.