Skip to content

Commit

Permalink
Change strict layout conformance to not use the new static changes (#…
Browse files Browse the repository at this point in the history
…41733)

Summary:
Pull Request resolved: #41733

I am currently implementing position: static in Yoga. I have a huge stack of changes that is ready to ship but we are waiting on the default position type to be relative before shipping. The reason being, my changes will affect a whole ton of styles where there is no position set so if we can make static no longer the default we can safely ship this new code. However, this will take a while and keeping up with this stack of diffs though merge conflicts, flakey tests, and general slowness for my IDE is getting annoying. So a solution here is to ship that stack and make it so that no one gets this functionality by changing the strict layout conformance to include the errata that is gating my changes. The end result being that the code can be shipped but will have no affect at the time being.

Right now, because that code is in a different branch and not on prod, this change will do nothing.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D51731778

fbshipit-source-id: f0b7fd8559adb19e1658b3ac64fcfc4c5f8ecdf7
  • Loading branch information
joevilches authored and facebook-github-bot committed Dec 1, 2023
1 parent 448e6b8 commit 01c627e
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,8 @@ YGErrata YogaLayoutableShadowNode::resolveErrata(YGErrata defaultErrata) const {
case LayoutConformance::Classic:
return YGErrataAll;
case LayoutConformance::Strict:
return YGErrataNone;
// This is temporary until the default position type is relative
return YGErrataPositionStaticBehavesLikeRelative;
case LayoutConformance::Undefined:
return defaultErrata;
}
Expand Down

0 comments on commit 01c627e

Please sign in to comment.