Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin code for "Communication Android" documentation #3070

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

junaidn
Copy link
Contributor

@junaidn junaidn commented Apr 11, 2022

This PR includes:
Sample code of Kotlin for docs/communication-android doc.

@facebook-github-bot
Copy link

Hi @junaidn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 6be7605
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/625663af77e7770009b018ce
😎 Deploy Preview https://deploy-preview-3070--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@junaidn
Copy link
Contributor Author

junaidn commented Apr 11, 2022

@cortinico @ShikaSD @mdvacca

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nits 👍 Looks good overall

override fun getLaunchOptions(): Bundle {
val initialProperties = Bundle()
val imageList =
ArrayList(listOf("http://foo.com/bar1.png", "http://foo.com/bar2.png"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

val initialProperties = Bundle()
val imageList =
ArrayList(listOf("http://foo.com/bar1.png", "http://foo.com/bar2.png"))
initialProperties.putStringArrayList("images", imageList)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword to:

val initialProperties = Bundle().apply {
    putStringArrayList("images", imageList)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 108 to 109
var imageList: ArrayList<String> =
ArrayList<String>(listOf("http://foo.com/bar3.png", "http://foo.com/bar4.png"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@junaidn junaidn requested a review from cortinico April 12, 2022 06:15
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small nit. Other than that, LGTM 👍

docs/communication-android.md Outdated Show resolved Hide resolved
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@cortinico cortinico merged commit 751c48c into facebook:main Apr 13, 2022
@cortinico
Copy link
Contributor

Thansk for doing this @junaidn 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants