Update view.md #1564
Merged
Update view.md #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating props to remove 'clickable' and add 'focusable '
cpojer
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating our application from
react-native@0.60.5to0.61.5, I got a code review comment from @joshniche about a snapshot I updated, where a View's props changed.We've seen default props change in previous migrations, but neither of us noticed anything in the changelog about this one so we did some digging.
This PR updates the View component's documentation to be consistent with changes from facebook/react-native#25274.
Note: I got the language directly from: https://github.com/facebook/react-native/blob/v0.61.5/Libraries/Components/View/ViewPropTypes.js#L314