Skip to content

Commit

Permalink
Merge pull request #887 from isa-bel/patch-1
Browse files Browse the repository at this point in the history
docs: Fix JDK and Gradle capitalization
  • Loading branch information
rickhanlonii authored Apr 15, 2019
2 parents 70ae916 + 7f36836 commit 9027020
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/signed-apk-android.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ This command prompts you for passwords for the keystore and key and for the Dist

The keystore contains a single key, valid for 10000 days. The alias is a name that you will use later when signing your app, so remember to take note of the alias.

On Mac, if you're not sure where your jdk bin folder is, then perform the following command to find it:
On Mac, if you're not sure where your JDK bin folder is, then perform the following command to find it:

$ /usr/libexec/java_home

It will output the directory of the jdk, which will look something like this:
It will output the directory of the JDK, which will look something like this:

/Library/Java/JavaVirtualMachines/jdkX.X.X_XXX.jdk/Contents/Home

Expand All @@ -29,7 +29,7 @@ Navigate to that directory by using the command `$ cd /your/jdk/path` and use th

_Note: Remember to keep your keystore file private and never commit it to version control._

### Setting up gradle variables
### Setting up Gradle variables

1. Place the `my-release-key.keystore` file under the `android/app` directory in your project folder.
2. Edit the file `~/.gradle/gradle.properties` or `android/gradle.properties`, and add the following (replace `*****` with the correct keystore password, alias and key password),
Expand All @@ -41,15 +41,15 @@ MYAPP_RELEASE_STORE_PASSWORD=*****
MYAPP_RELEASE_KEY_PASSWORD=*****
```

These are going to be global gradle variables, which we can later use in our gradle config to sign our app.
These are going to be global Gradle variables, which we can later use in our Gradle config to sign our app.

> **Note about saving the keystore:**
> Once you publish the app on the Play Store, you will need to republish your app under a different package name (losing all downloads and ratings) if you want to change the signing key at any point. So backup your keystore and don't forget the passwords.
_Note about security: If you are not keen on storing your passwords in plaintext, and you are running OSX, you can also [store your credentials in the Keychain Access app](https://pilloxa.gitlab.io/posts/safer-passwords-in-gradle/). Then you can skip the two last rows in `~/.gradle/gradle.properties`._

### Adding signing config to your app's gradle config
### Adding signing config to your app's Gradle config

Edit the file `android/app/build.gradle` in your project folder, and add the signing config,

Expand Down

0 comments on commit 9027020

Please sign in to comment.