Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network panel tests #149

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix network panel tests #149

merged 1 commit into from
Feb 5, 2025

Conversation

EdmondChuiHW
Copy link

@EdmondChuiHW EdmondChuiHW commented Feb 5, 2025 •
edited
Loading

Summary

Fix tests for NetworkPanel.test.ts. There are other failing tests to be fixed.

Test plan

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW marked this pull request as ready for review February 5, 2025 20:01
@EdmondChuiHW EdmondChuiHW merged commit c684970 into facebook:main Feb 5, 2025
2 of 3 checks passed
@EdmondChuiHW EdmondChuiHW deleted the fix-network-tests branch February 5, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq hoxyq approved these changes

@huntie huntie Awaiting requested review from huntie

@robhogan robhogan Awaiting requested review from robhogan

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdmondChuiHW @hoxyq @facebook-github-bot