Skip to content

Commit

Permalink
Remove useless evb loop/terminate in HQClient
Browse files Browse the repository at this point in the history
Summary: Remove useless evb loop/terminate in HQClient

Reviewed By: afrind

Differential Revision: D69151301

fbshipit-source-id: 9a6f8b46e33cbbf5c20050d380d2a25ead9cd71e
  • Loading branch information
kvtsoy authored and facebook-github-bot committed Feb 5, 2025
1 parent 919f79c commit e4b7cb2
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions proxygen/httpserver/samples/hq/HQClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ int HQClient::start() {
LOG(INFO) << "HQClient connecting to " << params_.remoteAddress->describe();
quicClient_->start(this, nullptr);

// This is to flush the CFIN out so the server will see the handshake as
// complete.
evb_.loopForever();
if (params_.migrateClient) {
quicClient_->onNetworkSwitch(
std::make_unique<FollyQuicAsyncUDPSocket>(qEvb_));
Expand Down Expand Up @@ -274,7 +271,6 @@ void HQClient::sendKnobFrame(const folly::StringPiece str) {
void HQClient::onReplaySafe() noexcept {
VLOG(4) << "Transport replay safe";
replaySafe_ = true;
evb_.terminateLoopSoon();
}

void HQClient::connectError(const quic::QuicError& error) {
Expand Down

0 comments on commit e4b7cb2

Please sign in to comment.