Skip to content

Commit

Permalink
Fix StatusTypeEnum bug
Browse files Browse the repository at this point in the history
Summary:
`StatusType::ENUM_COUNT` is used to bound the valid enums but its not the last one...
https://www.internalfb.com/code/fbsource/[b40ae6818e8b01d0e37ec0d35afe8f45269c73d1]/fbcode/proxygen/lib/http/StatusTypeEnum.cpp?lines=19-26

Differential Revision: D61672203

fbshipit-source-id: 5097fa47415f0081005c29d3ef2d65b85dc45b31
  • Loading branch information
mjsaltus authored and facebook-github-bot committed Aug 23, 2024
1 parent 0139656 commit c00aaa4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion proxygen/lib/http/StatusTypeEnum.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ namespace proxygen {
x(manifest_missing_representation), x(manifest_with_0_bitrate), \
x(manifest_with_no_tracks), x(manifest_with_wrong_track), \
x(cache_lease_queue_hard_timeout), x(cache_purge), x(cache_error), \
x(proxy_cache_fill_shed), x(ENUM_COUNT), x(takedown_direct_response)
x(proxy_cache_fill_shed), x(takedown_direct_response), \
/* ENUM_COUNT MUST BE THE FINAL ENUM */ x(ENUM_COUNT)

#define STATUS_TYPE_ENUM(statusType) statusType

Expand Down

0 comments on commit c00aaa4

Please sign in to comment.