remove unused TransportSettings shouldRecvBatch

Summary: shouldRecvBatch is not used by the transport. Reviewed By: lnicco Differential Revision: D59535361 fbshipit-source-id: 4085f463ffeb044d75aedc0e64c47daa61c28b5c
facebook · Jul 11, 2024 · a321ca1 · a321ca1
1 parent 5c4e0dd
commit a321ca1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/proxygen/httpclient/samples/httperf2/Client.cpp b/proxygen/httpclient/samples/httperf2/Client.cpp
@@ -212,7 +212,7 @@ static quic::TransportSettings createTransportSettings() {
   transportSettings.batchingMode =
       quic::getQuicBatchingMode(FLAGS_quic_batching_mode);
   transportSettings.maxBatchSize = FLAGS_quic_batch_size;
-  transportSettings.shouldRecvBatch = true;
+  transportSettings.shouldUseRecvmmsgForBatchRecv = true;
   transportSettings.maxRecvBatchSize = FLAGS_quic_recv_batch_size;
   transportSettings.connectUDP = FLAGS_udp_connect;
   transportSettings.shouldDrain = false;

diff --git a/proxygen/httpserver/samples/hq/HQCommandLine.cpp b/proxygen/httpserver/samples/hq/HQCommandLine.cpp
@@ -278,7 +278,6 @@ void initializeTransportSettings(HQToolParams& hqUberParams) {
                                                 kDefaultQuicTransportKnobId,
                                                 FLAGS_transport_knobs});
   }
-  hqParams.transportSettings.shouldRecvBatch = true;
   hqParams.transportSettings.maxRecvBatchSize = 32;
   hqParams.transportSettings.shouldUseRecvmmsgForBatchRecv = true;
   hqParams.transportSettings.advertisedInitialMaxStreamsBidi = 100;
@@ -304,10 +303,7 @@ void initializeTransportSettings(HQToolParams& hqUberParams) {
     hqParams.transportSettings.ccaConfig.leaveHeadroomForCwndLimited = true;
   }
 
-  if (FLAGS_read_ecn) {
-    hqParams.transportSettings.readEcnOnIngress = FLAGS_read_ecn;
-    hqParams.transportSettings.shouldRecvBatch = false;
-  }
+  hqParams.transportSettings.readEcnOnIngress = FLAGS_read_ecn;
 
   hqParams.transportSettings.dscpValue = FLAGS_dscp;
 } // initializeTransportSettings