Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use explicit crate features #306

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Only use explicit crate features #306

merged 1 commit into from
Feb 4, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Feb 1, 2023 •
edited
Loading

Analogous to facebook/voprf#100.
Requires #304.

Since we are now using Rust 1.60, we can use explicit crate features.
Rust-Analyzer had some serious issues with that extern crate serde_ as serde.
This also removes all implicit features, which is an improvement for users.

@daxpedda daxpedda force-pushed the explicit-crate-features branch 2 times, most recently from f9ea96e to 6642ea3 Compare February 1, 2023 15:11
@daxpedda daxpedda marked this pull request as draft February 1, 2023 15:12
@daxpedda daxpedda force-pushed the explicit-crate-features branch 6 times, most recently from 4d3ecb3 to 0c0af96 Compare February 3, 2023 23:01
@daxpedda daxpedda marked this pull request as ready for review February 4, 2023 09:58
@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 4, 2023

This is ready now!

kevinlewi
kevinlewi approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinlewi kevinlewi merged commit 09489dd into facebook:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxpedda @kevinlewi @facebook-github-bot