Skip to content

Commit

Permalink
Revert startup pacing gain to original
Browse files Browse the repository at this point in the history
Summary: Startup pacing gain had been changed for experimentation. Need to revert to the original value.

Reviewed By: jbeshay

Differential Revision: D68035989

fbshipit-source-id: 190f1c2699fa32eda533b04d059a712bc2ae9136
  • Loading branch information
ritengupta authored and facebook-github-bot committed Jan 14, 2025
1 parent 19b7198 commit ceb4072
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion quic/state/TransportSettings.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ struct CongestionControlConfig {
// Used by: BBR2
// Use a different pacing gain during Startup.
// If value < 0, use the default pacing gain.
float overrideStartupPacingGain{4.33f};
float overrideStartupPacingGain{-1.0};

// Used by: Cubic
// The target fraction of packets to be marked with CE per-RTT when l4s is
Expand Down
2 changes: 1 addition & 1 deletion quic/state/test/TransportSettingsFunctionsTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ TEST_F(TransportSettingsFunctionsTest, UnspecifiedFieldsAreDefaulted) {
EXPECT_EQ(config.enableRenoCoexistence, false);
EXPECT_EQ(config.overrideCruisePacingGain, -1.0f);
EXPECT_EQ(config.overrideCruiseCwndGain, -1.0f);
EXPECT_EQ(config.overrideStartupPacingGain, 4.33f);
EXPECT_EQ(config.overrideStartupPacingGain, -1.0f);

ASSERT_TRUE(config.ackFrequencyConfig.has_value());
EXPECT_EQ(
Expand Down

0 comments on commit ceb4072

Please sign in to comment.