Remove default case where possible to get compile errors instead

Summary: Removing the `default` case when we expect to handle each enum variant so that we'll get compile time type errors when updating enums. Reviewed By: arthaud Differential Revision: D47534915 fbshipit-source-id: 75be4ab16267340e0c5e153ce59dc6b287617811
facebook · Jul 19, 2023 · ebcc528 · ebcc528
1 parent 5b44c7b
commit ebcc528
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 14 deletions.
diff --git a/source/Access.cpp b/source/Access.cpp
@@ -101,10 +101,9 @@ std::string PathElement::to_string() const {
     case PathElement::Kind::IndexFromValueOf:
       return fmt::format(
           "[<{}>]", Root(Root::Kind::Argument, parameter_position()));
-
-    default:
-      mt_unreachable();
   }
+
+  mt_unreachable();
 }
 
 PathElement PathElement::from_json(const Json::Value& value) {
@@ -273,9 +272,10 @@ std::string Root::to_string() const {
       return "call-chain";
     case Root::Kind::CallEffectIntent:
       return "call-effect-intent";
-    default:
+    case Root::Kind::MaxArgument:
       mt_unreachable();
   }
+  mt_unreachable();
 }
 
 Json::Value Root::to_json() const {

diff --git a/source/Model.cpp b/source/Model.cpp
@@ -85,9 +85,8 @@ std::string model_mode_to_string(Model::Mode mode) {
       return "alias-memory-location-on-invoke";
     case Model::Mode::StrongWriteOnPropagation:
       return "strong-write-on-propagation";
-    default:
-      mt_unreachable();
   }
+  mt_unreachable();
 }
 
 std::optional<Model::Mode> string_to_model_mode(const std::string& mode) {

diff --git a/source/constraints/IntegerConstraint.cpp b/source/constraints/IntegerConstraint.cpp
@@ -32,11 +32,8 @@ bool IntegerConstraint::satisfy(int lhs) const {
     case Operator::EQ: {
       return lhs == rhs_;
     }
-    default: {
-      mt_unreachable();
-      return true;
-    }
   }
+  mt_unreachable();
 }
 
 bool IntegerConstraint::operator==(const IntegerConstraint& other) const {

diff --git a/source/constraints/TypeConstraints.cpp b/source/constraints/TypeConstraints.cpp
@@ -36,9 +36,8 @@ MethodHashedSet TypePatternConstraint::may_satisfy(
     case MaySatisfyMethodConstraintKind::Extends:
       return method_mappings.class_to_override_methods().get(
           *string_pattern, MethodHashedSet::bottom());
-    default:
-      mt_unreachable();
   }
+  mt_unreachable();
 }
 
 bool TypePatternConstraint::satisfy(const DexType* type) const {
@@ -67,9 +66,8 @@ MethodHashedSet TypeNameConstraint::may_satisfy(
     case MaySatisfyMethodConstraintKind::Extends:
       return method_mappings.class_to_override_methods().get(
           name_, MethodHashedSet::bottom());
-    default:
-      mt_unreachable();
   }
+  mt_unreachable();
 }
 
 bool TypeNameConstraint::satisfy(const DexType* type) const {