Skip to content

Commit

Permalink
Don't box cached value until it needs to be boxed
Browse files Browse the repository at this point in the history
Summary: Not sure why this was being boxed immediately - the correct thing to do is just to box when necessary (e.g. when doing comparisons), and have the model have the actual type (boxed or unboxed).

Reviewed By: astreet

Differential Revision: D16359485

fbshipit-source-id: 7e9c1031c5c484f0ed41db4a6ab81412f2be0035
  • Loading branch information
IanChilds authored and facebook-github-bot committed Jul 19, 2019
1 parent 97378ef commit 501f1a1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public TypeSpec getTypeSpec() {

@Override
public TypeName getTypeName() {
return mParamModel.getTypeName().box();
return mParamModel.getTypeName();
}

@Override
Expand Down

0 comments on commit 501f1a1

Please sign in to comment.