-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-react]Bug Fix: the location of draggable-block-menu cannot be calculated #6818 #6915
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @lin-mt! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
size-limit report 📦
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Do you mind updating the title of this issue to match the pull request template? For reference, here is what it says:
|
Okay, it's been updated. Sorry, I didn't notice the specification before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is hard to test in the playground but it seems like a better fallback than what we do now
Description
Closes #6818
Test plan
Before
In some cases it is not possible to get the
lineHeight
height of a dragged element, e.g.inherit
, when this happens use the height calculation of the Element.After