Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-react]Bug Fix: the location of draggable-block-menu cannot be calculated #6818 #6915

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

lin-mt
Copy link
Contributor

@lin-mt lin-mt commented Dec 6, 2024

Description

Closes #6818

Test plan

Before

In some cases it is not possible to get the lineHeight height of a dragged element, e.g. inherit, when this happens use the height calculation of the Element.

Clip_2024-12-06_15-10-28

After

Clip_2024-12-06_15-11-01

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:56pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:56pm

@facebook-github-bot
Copy link
Contributor

Hi @lin-mt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
lexical - cjs 31.15 KB (0%)
lexical - esm 30.95 KB (0%)
@lexical/rich-text - cjs 40.1 KB (0%)
@lexical/rich-text - esm 32.81 KB (0%)
@lexical/plain-text - cjs 38.73 KB (0%)
@lexical/plain-text - esm 30.14 KB (0%)
@lexical/react - cjs 41.99 KB (0%)
@lexical/react - esm 34.17 KB (0%)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@etrepum
Copy link
Collaborator

etrepum commented Dec 9, 2024

Do you mind updating the title of this issue to match the pull request template?

For reference, here is what it says:

Title format should be:
[Affected Packages] PR Type: title

Example:
[lexical-playground][lexical-link] Feature: Add more emojis

Choose from the following PR Types:
Breaking change / Refactor / Feature / Bug Fix / Documentation Update / Chore

@lin-mt lin-mt changed the title fix: #6818 [lexical-react]Bug Fix: the location of draggable-block-menu cannot be calculated #6818 Dec 9, 2024
@lin-mt
Copy link
Contributor Author

lin-mt commented Dec 9, 2024

Do you mind updating the title of this issue to match the pull request template?

For reference, here is what it says:

Title format should be:
[Affected Packages] PR Type: title
Example:
[lexical-playground][lexical-link] Feature: Add more emojis
Choose from the following PR Types:
Breaking change / Refactor / Feature / Bug Fix / Documentation Update / Chore

Okay, it's been updated. Sorry, I didn't notice the specification before

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is hard to test in the playground but it seems like a better fallback than what we do now

Merged via the queue into facebook:main with commit 42bd45d Dec 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: In storybook, DraggableBlockPlugin does not work
3 participants