Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-website] Fix: /docs/react/ "next" button links to itself #6911

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[lexical-website] Fix: /docs/react/ "next" button links to itself #6911

merged 2 commits into from
Dec 4, 2024

Conversation

vantage-ola
Copy link
Contributor

Closes #6881

Before Fix
Screenshot 2024-12-04 194751

After Fix
Screenshot 2024-12-04 194600

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 6:50pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 6:50pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size
lexical - cjs 31.07 KB (0%)
lexical - esm 30.92 KB (0%)
@lexical/rich-text - cjs 39.89 KB (0%)
@lexical/rich-text - esm 32.75 KB (0%)
@lexical/plain-text - cjs 38.46 KB (0%)
@lexical/plain-text - esm 30.08 KB (0%)
@lexical/react - cjs 41.79 KB (0%)
@lexical/react - esm 34.15 KB (0%)

etrepum
etrepum approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@etrepum etrepum added this pull request to the merge queue Dec 4, 2024
Merged via the queue into facebook:main with commit bccfeee Dec 4, 2024
9 checks passed
@vantage-ola vantage-ola deleted the fix-docs-page branch December 10, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: /docs/react/ "next" button links to itself
3 participants
@vantage-ola @etrepum @facebook-github-bot