[lexical-react] Fix(lexical-react): ContentEditable props type rename #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the type seems too generic, so I suggest renaming it to: Like the link below https://github.com/facebook/lexical/blob/main/packages/lexical-react/src/LexicalTablePlugin.ts
ivaaaaann
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
|
I think this probably makes sense but it doesn't maintain backwards compatibility. I would recommend also exporting it as Props, maybe with a |
|
@etrepum Thanks for the nice comment, I didn't think about that part! I modified it according to your comment. |
etrepum
reviewed
Nov 16, 2024
Comment on lines
32
to
39
| /** | ||
| * @deprecated This type has been renamed to `ContentEditableProps` to provide a clearer and more descriptive name. | ||
| * For backward compatibility, this type is still exported as `Props`, but it is recommended to migrate to using `ContentEditableProps` instead. | ||
| * | ||
| * @note This alias is maintained for compatibility purposes but may be removed in future versions. | ||
| * Please update your codebase to use `ContentEditableProps` to ensure long-term maintainability. | ||
| */ | ||
| export type Props = ContentEditableProps |
There was a problem hiding this comment.
I think the formatting here is causing CI to fail, npm run prettier:fix would resolve it
There was a problem hiding this comment.
thank you i fixed fix: prettier
etrepum
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name of the type seems too generic, so I suggest renaming it to:
Like the link below
https://github.com/facebook/lexical/blob/main/packages/lexical-react/src/LexicalTablePlugin.ts